chore: clean up CI scripts

* Skip signing and notarizing Darwin binary in pull requests,
  since this takes a long time and is done in the master build
* Avoid uploading built artifacts for pull request builds
* Only build/test for pull requests against master

Author: jawnsy

.github/workflows/build.yaml

@@ -1,5 +1,11 @@
 name: build
-on: [push]
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
 
 jobs:
   build:
@@ -10,30 +16,42 @@ jobs:
       - name: Build
         run: make -j build/linux build/windows
       - name: Upload
+        if: github.ref == 'refs/heads/master'
         uses: actions/upload-artifact@v2
         with:
           name: coder-cli
           path: ./ci/bin/coder-cli-*
+
   build_darwin:
     runs-on: macos-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v1
+        uses: actions/checkout@v2
       - name: Install Gon
+        if: github.ref == 'refs/heads/master'
         run: |
           brew tap mitchellh/gon
           brew install mitchellh/gon/gon
       - name: Import Signing Certificates
+        if: github.ref == 'refs/heads/master'
         uses: Apple-Actions/import-codesign-certs@v1
         with:
           p12-file-base64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }}
           p12-password: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_PASSWORD }}
-      - name: Build
+      - name: Build master
+        if: github.ref == 'refs/heads/master'
         run: make build/macos
         env:
           AC_USERNAME: ${{ secrets.AC_USERNAME }}
           AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
+      - name: Build pull request
+        if: github.ref != 'refs/heads/master'
+        run: CI=false make build/macos
+        env:
+          AC_USERNAME: ${{ secrets.AC_USERNAME }}
+          AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
       - name: Upload
+        if: github.ref == 'refs/heads/master'
         uses: actions/upload-artifact@v2
         with:
           name: coder-cli

.github/workflows/integration.yaml

@@ -1,6 +1,8 @@
 name: integration
 on:
   push:
+    branches:
+    - master
   schedule:
     - cron:  '*/180 * * * *'
 
@@ -12,15 +14,15 @@ jobs:
       CODER_EMAIL: ${{ secrets.CODER_EMAIL }}
       CODER_PASSWORD: ${{ secrets.CODER_PASSWORD }}
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/cache@v1
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
       - uses: actions/setup-go@v2
         with:
-          go-version: '^1.14'
+          go-version: '^1.15'
       - name: integration tests
         run: ./ci/scripts/integration.sh

.github/workflows/test.yaml

@@ -1,12 +1,18 @@
 name: test
-on: [push]
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    branches:
+    - master
 
 jobs:
   fmt:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/cache@v1
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -25,12 +31,12 @@ jobs:
         uses: golangci/golangci-lint-action@v2
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.29
+          version: v1.36
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/cache@v1
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -43,8 +49,8 @@ jobs:
   gendocs:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: actions/cache@v1
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}