Skip to content

flake: cli: goleak: unexpected goroutine database/sql.(*DB).connectionOpener #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnstcn opened this issue Jan 28, 2025 · 5 comments
Assignees
Labels

Comments

@johnstcn
Copy link
Member

Seen here: https://github.com/coder/coder/actions/runs/13011725097/job/36290801887?pr=16306

=== Failed
=== FAIL: cli  (0.00s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 219852 in state select, with database/sql.(*DB).connectionOpener on top of the stack:
database/sql.(*DB).connectionOpener(0xc01ca140d0, {0x4c3ef28, 0xc06e22e7d0})
	/opt/hostedtoolcache/go/1.22.8/x64/src/database/sql/sql.go:1246 +0x87
created by database/sql.OpenDB in goroutine 201834
	/opt/hostedtoolcache/go/1.22.8/x64/src/database/sql/sql.go:824 +0x14c
]
FAIL	github.com/coder/coder/v2/cli	83.437s
@johnstcn johnstcn added the flake label Jan 28, 2025
@johnstcn
Copy link
Member Author

johnstcn commented Jan 28, 2025

I tried following the process outlined here to identify more closely the source of the goroutine leak.

Four tests failed with this approach, but for unrelated reasons (missing embedded files in the test binary):

  • TestErrorExamples
  • TestProvisioners_Golden
  • TestCommandHelp
  • TestServerYAMLConfig

Going to leave this open to hopefully collect some more data points.

@johnstcn
Copy link
Member Author

@Kira-Pilot do you have another example of where this flaked?

@Kira-Pilot
Copy link
Member

Hi @johnstcn, I don't! We were just grooming some tickets and I saw you were using this to collect data so I put your name on it. Feel free to unassign if that doesn't make sense. :)

@spikecurtis
Copy link

@johnstcn
Copy link
Member Author

Related to golang/go#50616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants