Skip to content

flake: data race in cli package with postgres enabled #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
johnstcn opened this issue Feb 18, 2025 · 0 comments
Open

flake: data race in cli package with postgres enabled #384

johnstcn opened this issue Feb 18, 2025 · 0 comments
Assignees
@DanielleMaywood
Labels
flake

Comments

@johnstcn
Copy link
Member

Seen here: https://github.com/coder/coder/actions/runs/13394205515

2025-02-18T15:55:09.3797881Z ==================
2025-02-18T15:55:09.3798046Z WARNING: DATA RACE
2025-02-18T15:55:09.3798226Z Write at 0x00c0008fe930 by goroutine 11593:
2025-02-18T15:55:09.3798451Z   runtime.slicecopy()
2025-02-18T15:55:09.3798952Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/slice.go:325 +0x0
2025-02-18T15:55:09.3799332Z   bufio.(*Reader).Read()
2025-02-18T15:55:09.3799784Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/bufio/bufio.go:254 +0x68c
2025-02-18T15:55:09.3800269Z   io.ReadAtLeast()
2025-02-18T15:55:09.3800728Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/io/io.go:335 +0xcf
2025-02-18T15:55:09.3801104Z   io.ReadFull()
2025-02-18T15:55:09.3801541Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/io/io.go:354 +0x35e
2025-02-18T15:55:09.3801924Z   github.com/lib/pq.(*conn).recvMessage()
2025-02-18T15:55:09.3802434Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/conn.go:1032 +0x2fb
2025-02-18T15:55:09.3802827Z   github.com/lib/pq.(*conn).recv1Buf()
2025-02-18T15:55:09.3803374Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/conn.go:1073 +0x34
2025-02-18T15:55:09.3803720Z   github.com/lib/pq.(*rows).Next()
2025-02-18T15:55:09.3804175Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/conn.go:1587 +0x264
2025-02-18T15:55:09.3804604Z   github.com/lib/pq.(*rows).Close()
2025-02-18T15:55:09.3805048Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/conn.go:1544 +0xaf
2025-02-18T15:55:09.3805451Z   database/sql.(*Rows).close.func1()
2025-02-18T15:55:09.3805956Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3412 +0x57
2025-02-18T15:55:09.3806335Z   database/sql.withLock()
2025-02-18T15:55:09.3806812Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3530 +0xa6
2025-02-18T15:55:09.3807204Z   database/sql.(*Rows).close()
2025-02-18T15:55:09.3807683Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3411 +0x28a
2025-02-18T15:55:09.3808086Z   database/sql.(*Rows).awaitDone()
2025-02-18T15:55:09.3808593Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3001 +0x2bb
2025-02-18T15:55:09.3809020Z   database/sql.(*Rows).initContextClose.gowrap1()
2025-02-18T15:55:09.3809555Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:2977 +0x8f
2025-02-18T15:55:09.3809956Z 
2025-02-18T15:55:09.3810076Z Previous read at 0x00c0008fe930 by goroutine 11571:
2025-02-18T15:55:09.3810317Z   runtime.slicebytetostring()
2025-02-18T15:55:09.3810774Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/runtime/string.go:81 +0x0
2025-02-18T15:55:09.3811128Z   github.com/google/uuid.(*UUID).Scan()
2025-02-18T15:55:09.3811500Z       /home/runner/go/pkg/mod/github.com/google/[email protected]/sql.go:43 +0x244
2025-02-18T15:55:09.3811796Z   database/sql.convertAssignRows()
2025-02-18T15:55:09.3812295Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/convert.go:385 +0x2ba2
2025-02-18T15:55:09.3812665Z   database/sql.(*Rows).Scan()
2025-02-18T15:55:09.3813121Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3354 +0x704
2025-02-18T15:55:09.3813473Z   database/sql.(*Row).Scan()
2025-02-18T15:55:09.3813930Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:3473 +0x2e4
2025-02-18T15:55:09.3814423Z   github.com/coder/coder/v2/coderd/database.(*sqlQuerier).GetDefaultOrganization()
2025-02-18T15:55:09.3814906Z       /home/runner/work/coder/coder/coderd/database/queries.sql.go:5096 +0x2d8
2025-02-18T15:55:09.3815367Z   github.com/coder/coder/v2/coderd/database/dbmetrics.(*metricsStore).GetDefaultOrganization()
2025-02-18T15:55:09.3815737Z       <autogenerated>:1 +0xd0
2025-02-18T15:55:09.3816099Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization.func1()
2025-02-18T15:55:09.3816631Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:1602 +0xd0
2025-02-18T15:55:09.3820192Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization.fetch[go.shape.interface {},go.shape.struct { ID github.com/google/uuid.UUID "db:\"id\" json:\"id\""; Name string "db:\"name\" json:\"name\""; Description string "db:\"description\" json:\"description\""; CreatedAt time.Time "db:\"created_at\" json:\"created_at\""; UpdatedAt time.Time "db:\"updated_at\" json:\"updated_at\""; IsDefault bool "db:\"is_default\" json:\"is_default\""; DisplayName string "db:\"display_name\" json:\"display_name\""; Icon string "db:\"icon\" json:\"icon\"" },go.shape.func(context.Context, interface {}) (github.com/coder/coder/v2/coderd/database.Organization, error)].fetchWithAction[go.shape.interface {},go.shape.struct { ID github.com/google/uuid.UUID "db:\"id\" json:\"id\""; Name string "db:\"name\" json:\"name\""; Description string "db:\"description\" json:\"description\""; CreatedAt time.Time "db:\"created_at\" json:\"created_at\""; UpdatedAt time.Time "db:\"updated_at\" json:\"updated_at\""; IsDefault bool "db:\"is_default\" json:\"is_default\""; DisplayName string "db:\"display_name\" json:\"display_name\""; Icon string "db:\"icon\" json:\"icon\"" },go.shape.func(context.Context, interface {}) (github.com/coder/coder/v2/coderd/database.Organization, error)].func2()
2025-02-18T15:55:09.3823257Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:550 +0x1cb
2025-02-18T15:55:09.3823725Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization()
2025-02-18T15:55:09.3824256Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:1603 +0x2e1
2025-02-18T15:55:09.3824694Z   github.com/coder/coder/v2/coderd.(*API).CreateInMemoryTaggedProvisionerDaemon()
2025-02-18T15:55:09.3825127Z       /home/runner/work/coder/coder/coderd/coderd.go:1611 +0x49b
2025-02-18T15:55:09.3825495Z   github.com/coder/coder/v2/coderd.(*API).CreateInMemoryProvisionerDaemon()
2025-02-18T15:55:09.3825902Z       /home/runner/work/coder/coder/coderd/coderd.go:1596 +0xa8
2025-02-18T15:55:09.3826232Z   github.com/coder/coder/v2/cli.newProvisionerDaemon.func6()
2025-02-18T15:55:09.3826588Z       /home/runner/work/coder/coder/cli/server.go:1457 +0x1a
2025-02-18T15:55:09.3826880Z   github.com/coder/coder/v2/provisionerd.(*Server).connect()
2025-02-18T15:55:09.3827286Z       /home/runner/work/coder/coder/provisionerd/provisionerd.go:225 +0x495
2025-02-18T15:55:09.3827622Z   github.com/coder/coder/v2/provisionerd.New.gowrap1()
2025-02-18T15:55:09.3828028Z       /home/runner/work/coder/coder/provisionerd/provisionerd.go:109 +0x33
2025-02-18T15:55:09.3828236Z 
2025-02-18T15:55:09.3828317Z Goroutine 11593 (running) created at:
2025-02-18T15:55:09.3828548Z   database/sql.(*Rows).initContextClose()
2025-02-18T15:55:09.3829048Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:2977 +0x22f
2025-02-18T15:55:09.3829413Z   database/sql.(*DB).queryDC()
2025-02-18T15:55:09.3829967Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1790 +0xa6d
2025-02-18T15:55:09.3830332Z   database/sql.(*DB).query()
2025-02-18T15:55:09.3830790Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1754 +0x168
2025-02-18T15:55:09.3831166Z   database/sql.(*DB).QueryContext.func1()
2025-02-18T15:55:09.3831648Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1732 +0xcf
2025-02-18T15:55:09.3831996Z   database/sql.(*DB).retry()
2025-02-18T15:55:09.3832442Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1566 +0x4a
2025-02-18T15:55:09.3832807Z   database/sql.(*DB).QueryContext()
2025-02-18T15:55:09.3833278Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1731 +0x184
2025-02-18T15:55:09.3833637Z   database/sql.(*DB).QueryRowContext()
2025-02-18T15:55:09.3834106Z       /home/runner/go/pkg/mod/golang.org/[email protected]/src/database/sql/sql.go:1832 +0xb2
2025-02-18T15:55:09.3834498Z   github.com/jmoiron/sqlx.(*DB).QueryRowContext()
2025-02-18T15:55:09.3834745Z       <autogenerated>:1 +0x1f
2025-02-18T15:55:09.3835081Z   github.com/coder/coder/v2/coderd/database.(*sqlQuerier).GetDefaultOrganization()
2025-02-18T15:55:09.3835556Z       /home/runner/work/coder/coder/coderd/database/queries.sql.go:5094 +0xc6
2025-02-18T15:55:09.3836024Z   github.com/coder/coder/v2/coderd/database/dbmetrics.(*metricsStore).GetDefaultOrganization()
2025-02-18T15:55:09.3836387Z       <autogenerated>:1 +0xd0
2025-02-18T15:55:09.3836743Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization.func1()
2025-02-18T15:55:09.3837252Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:1602 +0xd0
2025-02-18T15:55:09.3840773Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization.fetch[go.shape.interface {},go.shape.struct { ID github.com/google/uuid.UUID "db:\"id\" json:\"id\""; Name string "db:\"name\" json:\"name\""; Description string "db:\"description\" json:\"description\""; CreatedAt time.Time "db:\"created_at\" json:\"created_at\""; UpdatedAt time.Time "db:\"updated_at\" json:\"updated_at\""; IsDefault bool "db:\"is_default\" json:\"is_default\""; DisplayName string "db:\"display_name\" json:\"display_name\""; Icon string "db:\"icon\" json:\"icon\"" },go.shape.func(context.Context, interface {}) (github.com/coder/coder/v2/coderd/database.Organization, error)].fetchWithAction[go.shape.interface {},go.shape.struct { ID github.com/google/uuid.UUID "db:\"id\" json:\"id\""; Name string "db:\"name\" json:\"name\""; Description string "db:\"description\" json:\"description\""; CreatedAt time.Time "db:\"created_at\" json:\"created_at\""; UpdatedAt time.Time "db:\"updated_at\" json:\"updated_at\""; IsDefault bool "db:\"is_default\" json:\"is_default\""; DisplayName string "db:\"display_name\" json:\"display_name\""; Icon string "db:\"icon\" json:\"icon\"" },go.shape.func(context.Context, interface {}) (github.com/coder/coder/v2/coderd/database.Organization, error)].func2()
2025-02-18T15:55:09.3843757Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:550 +0x1cb
2025-02-18T15:55:09.3844227Z   github.com/coder/coder/v2/coderd/database/dbauthz.(*querier).GetDefaultOrganization()
2025-02-18T15:55:09.3844741Z       /home/runner/work/coder/coder/coderd/database/dbauthz/dbauthz.go:1603 +0x2e1
2025-02-18T15:55:09.3845176Z   github.com/coder/coder/v2/coderd.(*API).CreateInMemoryTaggedProvisionerDaemon()
2025-02-18T15:55:09.3845608Z       /home/runner/work/coder/coder/coderd/coderd.go:1611 +0x49b
2025-02-18T15:55:09.3845972Z   github.com/coder/coder/v2/coderd.(*API).CreateInMemoryProvisionerDaemon()
2025-02-18T15:55:09.3846385Z       /home/runner/work/coder/coder/coderd/coderd.go:1596 +0xa8
2025-02-18T15:55:09.3846728Z   github.com/coder/coder/v2/cli.newProvisionerDaemon.func6()
2025-02-18T15:55:09.3847082Z       /home/runner/work/coder/coder/cli/server.go:1457 +0x1a
2025-02-18T15:55:09.3847385Z   github.com/coder/coder/v2/provisionerd.(*Server).connect()
2025-02-18T15:55:09.3847792Z       /home/runner/work/coder/coder/provisionerd/provisionerd.go:225 +0x495
2025-02-18T15:55:09.3848126Z   github.com/coder/coder/v2/provisionerd.New.gowrap1()
2025-02-18T15:55:09.3848523Z       /home/runner/work/coder/coder/provisionerd/provisionerd.go:109 +0x33
2025-02-18T15:55:09.3848735Z 
2025-02-18T15:55:09.3848817Z Goroutine 11571 (running) created at:
2025-02-18T15:55:09.3849056Z   github.com/coder/coder/v2/provisionerd.New()
2025-02-18T15:55:09.3849437Z       /home/runner/work/coder/coder/provisionerd/provisionerd.go:109 +0xa11
2025-02-18T15:55:09.3849762Z   github.com/coder/coder/v2/cli.newProvisionerDaemon()
2025-02-18T15:55:09.3850196Z       /home/runner/work/coder/coder/cli/server.go:1454 +0x2192
2025-02-18T15:55:09.3850495Z   github.com/coder/coder/v2/cli.(*RootCmd).Server.func2()
2025-02-18T15:55:09.3850836Z       /home/runner/work/coder/coder/cli/server.go:976 +0xb3fb
2025-02-18T15:55:09.3851132Z   github.com/coder/coder/v2/cli.(*RootCmd).Command.func6.1()
2025-02-18T15:55:09.3851465Z       /home/runner/work/coder/coder/cli/root.go:319 +0x14d
2025-02-18T15:55:09.3851842Z   github.com/coder/coder/v2/cli.(*RootCmd).Command.func7.PrintDeprecatedOptions.2.1()
2025-02-18T15:55:09.3852256Z       /home/runner/work/coder/coder/cli/root.go:1356 +0x216
2025-02-18T15:55:09.3852641Z   github.com/coder/coder/v2/cli.(*RootCmd).Server.RequireNArgs.RequireRangeArgs.func6.1()
2025-02-18T15:55:09.3853152Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/command.go:753 +0x604
2025-02-18T15:55:09.3853545Z   github.com/coder/coder/v2/cli.(*RootCmd).Server.WriteConfigMW.func5.1()
2025-02-18T15:55:09.3853935Z       /home/runner/work/coder/coder/cli/server.go:1290 +0x376
2025-02-18T15:55:09.3854208Z   github.com/coder/serpent.(*Invocation).run()
2025-02-18T15:55:09.3854605Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/command.go:499 +0x2666
2025-02-18T15:55:09.3855005Z   github.com/coder/serpent.(*Invocation).run()
2025-02-18T15:55:09.3855392Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/command.go:419 +0x1709
2025-02-18T15:55:09.3855702Z   github.com/coder/serpent.(*Invocation).Run()
2025-02-18T15:55:09.3856138Z       /home/runner/go/pkg/mod/github.com/coder/[email protected]/command.go:594 +0x356
2025-02-18T15:55:09.3856583Z   github.com/coder/coder/v2/cli_test.TestServer_TelemetryDisabled_FinalReport.func1.1()
2025-02-18T15:55:09.3857027Z       /home/runner/work/coder/coder/cli/server_test.go:2033 +0x64
2025-02-18T15:55:09.3857263Z ==================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielleMaywood DanielleMaywood

Labels
flake
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnstcn @DanielleMaywood