Skip to content

Commit d3f7583

Browse files
committed
feat: change user honors defaults'
1 parent 55550d4 commit d3f7583

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

src/client/Preview.tsx

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,12 @@ export const Preview: FC = () => {
237237
) : null}
238238
</AnimatePresence>
239239
</div>
240-
<UserSelect />
240+
<UserSelect changeUser={() => {
241+
// When you change the user, reset the form and the parameters.
242+
// This is a bit of a janky way to fully reset the form, but it works for now.
243+
$resetForm();
244+
$setParameters([]);
245+
}}/>
241246
</div>
242247
}
243248
{$parameters.length === 0 ? (
@@ -542,9 +547,8 @@ const FormElement: FC<FormElementProps> = ({ parameter }) => {
542547
const value = useMemo(
543548
() =>
544549
$form[parameter.name] ??
545-
(parameter.default_value.value === "??"
546-
? ""
547-
: parameter.default_value.value),
550+
// undefined is ok, the parameter will select the default automatically
551+
undefined,
548552
[$form, parameter],
549553
);
550554

@@ -563,7 +567,11 @@ const FormElement: FC<FormElementProps> = ({ parameter }) => {
563567
);
564568
};
565569

566-
const UserSelect: FC = () => {
570+
interface UserSelectProps {
571+
changeUser: () => void;
572+
}
573+
574+
const UserSelect: FC<UserSelectProps> = ({changeUser}) => {
567575
const $setWorkspaceOwner = useStore((state) => state.setWorkspaceOwner);
568576

569577
return (
@@ -572,6 +580,7 @@ const UserSelect: FC = () => {
572580
onValueChange={(value) => {
573581
const users: Record<string, WorkspaceOwner | undefined> = mockUsers;
574582
$setWorkspaceOwner(users[value] ?? mockUsers.admin);
583+
changeUser();
575584
}}
576585
>
577586
<SelectTrigger className="w-fit min-w-40">

0 commit comments

Comments
 (0)