Skip to content

pass headers to coder api #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Liorba opened this issue Apr 5, 2023 · 3 comments · Fixed by #119 or coder/coder#9059
Closed

pass headers to coder api #76

Liorba opened this issue Apr 5, 2023 · 3 comments · Fixed by #119 or coder/coder#9059
Assignees

Comments

@Liorba
Copy link

Liorba commented Apr 5, 2023

Hello coder team!
Our coder deployment is put behind a vpn so in order to send api calls to our control plan every request needs to have additional header holding our vpn session token.

in the vscode-coder code base, I noticed the user of axios, which can accept additional headers.
The problem resides in the fact that some of the api called are in the coder codebase and I'm not sure what's the preferred way to propagate those headers to the axios client in the coder coder base.

please advice on the preferred path and I'll be happy contribute!

@kylecarbs
Copy link
Member

We can certainly do this!

Would having a VS Code setting that allows the configuration of additional headers solve this? Then we can just set the global headers in Axios on change.

@Liorba
Copy link
Author

Liorba commented Apr 17, 2023

@kylecarbs I've added support for VPN headers in #81

@code-asher
Copy link
Member

code-asher commented Aug 15, 2023

I accidentally closed this with some bad wording in the Coder PR, still need to merge in the plugin PR for this to be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants