Skip to content

Commit 685a56e

Browse files
committed
Update README.md to indicate assembly websocket masking
1 parent 14172e5 commit 685a56e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ go get nhooyr.io/websocket
2626
- [RFC 7692](https://tools.ietf.org/html/rfc7692) permessage-deflate compression
2727
- [CloseRead](https://pkg.go.dev/nhooyr.io/websocket#Conn.CloseRead) helper for write only connections
2828
- Compile to [Wasm](https://pkg.go.dev/nhooyr.io/websocket#hdr-Wasm)
29+
- WebSocket masking implemented in assembly for amd64 and arm64 [#326](https://github.com/nhooyr/websocket/issues/326)
2930

3031
## Roadmap
3132

@@ -36,8 +37,6 @@ See GitHub issues for minor issues but the major future enhancements are:
3637
- [ ] Ping pong heartbeat helper [#267](https://github.com/nhooyr/websocket/issues/267)
3738
- [ ] Ping pong instrumentation callbacks [#246](https://github.com/nhooyr/websocket/issues/246)
3839
- [ ] Graceful shutdown helpers [#209](https://github.com/nhooyr/websocket/issues/209)
39-
- [ ] Assembly for WebSocket masking [#16](https://github.com/nhooyr/websocket/issues/16)
40-
- WIP at [#326](https://github.com/nhooyr/websocket/pull/326), about 3x faster
4140
- [ ] HTTP/2 [#4](https://github.com/nhooyr/websocket/issues/4)
4241
- [ ] The holy grail [#402](https://github.com/nhooyr/websocket/issues/402)
4342

@@ -121,7 +120,7 @@ Advantages of nhooyr.io/websocket:
121120
- Gorilla requires registering a pong callback before sending a Ping
122121
- Can target Wasm ([gorilla/websocket#432](https://github.com/gorilla/websocket/issues/432))
123122
- Transparent message buffer reuse with [wsjson](https://pkg.go.dev/nhooyr.io/websocket/wsjson) subpackage
124-
- [1.75x](https://github.com/nhooyr/websocket/releases/tag/v1.7.4) faster WebSocket masking implementation in pure Go
123+
- [3x](https://github.com/nhooyr/websocket/pull/326) faster WebSocket masking implementation in assembly for amd64 and arm64 and [2x](https://github.com/nhooyr/websocket/releases/tag/v1.7.4) faster implementation in pure Go
125124
- Gorilla's implementation is slower and uses [unsafe](https://golang.org/pkg/unsafe/).
126125
Soon we'll have assembly and be 3x faster [#326](https://github.com/nhooyr/websocket/pull/326)
127126
- Full [permessage-deflate](https://tools.ietf.org/html/rfc7692) compression extension support

0 commit comments

Comments
 (0)