Skip to content

Commit d1c3ad6

Browse files
committed
improved unit tests
1 parent 8e9744f commit d1c3ad6

File tree

7 files changed

+24
-16
lines changed

7 files changed

+24
-16
lines changed

test/load-context.spec.js

Whitespace-only changes.

test/result-fail.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ var config = {
99
dir: rootDir.slice(0, rootDir.length - 1).join('/'),
1010
tutorialDir: path.join(__dirname, 'tests')
1111
};
12-
var getRunner = require('./utils').getRunner;
12+
var getRunner = require('./utils/runner').getRunner;
1313

1414
describe('result-failure', function() {
1515

test/result-pass.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var chaiAsPromised = require("chai-as-promised");
33
chai.use(chaiAsPromised);
44
var expect = chai.expect;
55

6-
var getRunner = require('./utils').getRunner;
6+
var getRunner = require('./utils/runner').getRunner;
77

88
describe('result-pass', function() {
99

test/runner.spec.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ chai.use(spies);
66
chai.use(chaiAsPromised);
77
var expect = chai.expect;
88

9-
10-
var getRunner = require('./utils').getRunner;
11-
9+
var getRunner = require('./utils/runner').getRunner;
1210

1311
describe('runner', function() {
1412

@@ -21,13 +19,19 @@ describe('runner', function() {
2119
});
2220

2321

24-
xit('should load environmental variables', function () {
25-
var spy = chai.spy.on(handleLog);
22+
it('should load environmental variables', function () {
2623
var files = [
2724
['env-vars.js']
2825
];
2926
var run = getRunner(files);
30-
return expect(spy).to.have.been.called();
27+
var expected = {
28+
pass: true,
29+
taskPosition: 1,
30+
failedAtFile: null,
31+
msg: 'env-vars should pass'
32+
};
33+
34+
return expect(run).to.eventually.deep.equal(expected);
3135
});
3236

3337
});

test/tests/env-vars.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
var expect = require('chai').expect;
22

3-
describe('pass-01', function () {
4-
5-
console.log(process.env.DIR);
6-
console.log(process.env.TUTORIAL_DIR);
7-
3+
describe('env-vars', function () {
4+
85
it('should pass', function () {
9-
expect(true).to.be.true;
6+
expect(process.env.DIR).to.be.a('string');
7+
expect(process.env.TUTORIAL_DIR).to.be.a('string');
108
});
119

1210
});

test/utils/loadContext.js

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
var vm = require('vm');
2+
var fs = require('fs');
3+
module.exports = function loadContext(pathToContext) {
4+
var context = fs.readFileSync(pathToContext, 'utf8');
5+
vm.runInThisContext(context);
6+
};

test/utils.js renamed to test/utils/runner.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ function addPaths(files) {
88
});
99
}
1010

11-
var runner = require('../src/runner').runner;
11+
var runner = require('../../src/runner').default;
1212
var rootDir = __dirname.split('/');
1313
var config = {
1414
dir: rootDir.slice(0, rootDir.length - 1).join('/'),
15-
tutorialDir: __dirname + '/tests'
15+
tutorialDir: path.join(__dirname, '..', '/tests')
1616
};
1717
function handleLog(log) {
1818
return log;

0 commit comments

Comments
 (0)