[NTOS:PS] Enable alignment probing for thread/process information classes

In addition to that, here are some stuff done in this commit whilst testing:

- ICIF_QUERY_SIZE_VARIABLE and friends were badly misused, they should be used only when an information class whose information length size is dyanmic and not fixed. By removing such flags from erroneous classes, this fixes the STATUS_INFO_LENGTH_MISMATCH testcases.

- Use CHAR instead of UCHAR for classes that do not need alignment probing, as every other class in the table do, for the sake of consistency.

- ProcessEnableAlignmentFaultFixup uses BOOLEAN as type size, not CHAR. This fixes a testcase failure on ROS.

- Check for information length size before proceeding further on querying the process' cookie information.

- ProcessHandleTracing wants an alignment of a ULONG, not CHAR.

- Move PROCESS_LDT_INFORMATION and PROCESS_LDT_SIZE outside of NTOS_MODE_USER macro case. This fixes a compilation issue when enabling the alignment probing. My mistake of having them inside NTOS_MODE_USER case, sorry.

- On functions like NtQueryInformationThread and the Process equivalent, complete probing is not done at the beginning of the function, complete probing including if the buffer is writable alongside with datatype misalignment check that is. Instead such check is done on each information class case basis. With that said, we have to explicitly tell DefaultQueryInfoBufferCheck if we want a complete probing or not initially.

Author: GeoB99

ntoskrnl/ex/event.c

@@ -333,7 +333,8 @@ NtQueryEvent(IN HANDLE EventHandle,
                                          EventInformationLength,
                                          ReturnLength,
                                          NULL,
-                                         PreviousMode);
+                                         PreviousMode,
+                                         TRUE);
     if(!NT_SUCCESS(Status))
     {
         /* Invalid buffers */

ntoskrnl/ex/mutant.c

@@ -243,7 +243,8 @@ NtQueryMutant(IN HANDLE MutantHandle,
                                          MutantInformationLength,
                                          ResultLength,
                                          NULL,
-                                         PreviousMode);
+                                         PreviousMode,
+                                         TRUE);
     if(!NT_SUCCESS(Status))
     {
         DPRINT("NtQueryMutant() failed, Status: 0x%x\n", Status);

ntoskrnl/ex/sem.c

@@ -239,7 +239,8 @@ NtQuerySemaphore(IN HANDLE SemaphoreHandle,
                                          SemaphoreInformationLength,
                                          ReturnLength,
                                          NULL,
-                                         PreviousMode);
+                                         PreviousMode,
+                                         TRUE);
     if (!NT_SUCCESS(Status))
     {
         /* Invalid buffers */

ntoskrnl/ex/timer.c

@@ -536,7 +536,8 @@ NtQueryTimer(IN HANDLE TimerHandle,
                                          TimerInformationLength,
                                          ReturnLength,
                                          NULL,
-                                         PreviousMode);
+                                         PreviousMode,
+                                         TRUE);
     if (!NT_SUCCESS(Status)) return Status;
 
     /* Get the Timer Object */

ntoskrnl/include/internal/probe.h

@@ -63,7 +63,8 @@ DefaultQueryInfoBufferCheck(ULONG Class,
                             ULONG BufferLength,
                             PULONG ReturnLength,
                             PULONG_PTR ReturnLengthPtr,
-                            KPROCESSOR_MODE PreviousMode)
+                            KPROCESSOR_MODE PreviousMode,
+                            BOOLEAN CompleteProbing)
 {
     NTSTATUS Status = STATUS_SUCCESS;
 
@@ -90,9 +91,18 @@ DefaultQueryInfoBufferCheck(ULONG Class,
                 {
                     if (Buffer != NULL)
                     {
-                        ProbeForWrite(Buffer,
-                                      BufferLength,
-                                      ClassList[Class].AlignmentQUERY);
+                        if (!CompleteProbing)
+                        {
+                            ProbeForRead(Buffer,
+                                         BufferLength,
+                                         ClassList[Class].AlignmentQUERY);
+                        }
+                        else
+                        {
+                            ProbeForWrite(Buffer,
+                                          BufferLength,
+                                          ClassList[Class].AlignmentQUERY);
+                        }
                     }
 
                     if (ReturnLength != NULL)