Skip to content

Web-Js-Script Icon Coloring is not working. #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
7 tasks
Adam3371 opened this issue Jun 13, 2024 · 0 comments
Open
7 tasks

Web-Js-Script Icon Coloring is not working. #384

Adam3371 opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Adam3371
Copy link
Contributor

Why

For our web-js-script package the icon coloring is not working resulting in not visible icons in our compontent. Colors seem to be set or to white or to black resulting in different icons missing in light and dark themes.

Issue can be seen observed in this demo page

TODOS

  • Find out how to support icon coloring for web-js-script and adjust the component in a way, that the screen looks identical as in React and Web-Js.
  • Component must support dark and light theme as in the React and Web-Js component.
  • Check that Icon Coloring is supported in every screen in dark and in light mode and screens are identical als React and Web-Js.
  • Release the new version for web-js-script
  • Remove the Note in the Documentation that says that JS components added via CDN are not supporting Icon coloring.
  • Bump the version of web-js-script for the [Web-js-script] Demo Application](https://web-js-script.demo.corbado.io/#signup-init)

Acceptance criteria

  • There should be no difference between Web-Js or Web-js-script.

Implementation idea

Here you can write down an implementation idea how you would implement this issue (where do put this feature like in what domain, what service, what layer, naming/key of the feature in the code).

@Adam3371 Adam3371 added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants