WL#11226: Clear all compile warnings -- post push fixes

- do not add virtual ~DbDoc() dtor to not change the ABI
- add _CRT_SECURE_NO_WARNINGS on Win also when using clang compiler
- do not use set_compile_flag() for plain C compiler flags

Author: rsomla1

CMakeLists.txt

@@ -290,7 +290,7 @@ if(WERROR)
   set(WERROR -Werror)
 endif()
 
-if(MSVC)
+if(MSVC OR TOOLSET_MSVC)
 
   add_definitions(-D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS)
 

cdk/extra/zlib/CMakeLists.txt

@@ -25,7 +25,7 @@ if(WIN32)
   # conformant name: _open. See online help for details.
 
   if(CLANG)
-    set_compiler_flag(-Wno-deprecated-declarations)
+    add_compile_options(-Wno-deprecated-declarations)
   else()
     add_compile_options(/wd4996)
   endif()

include/mysqlx/devapi/document.h

@@ -172,8 +172,6 @@ DLL_WARNINGS_POP
   virtual Iterator begin();
   virtual Iterator end();
 
-  virtual ~DbDoc() {}
-
   friend Impl;
   friend DocResult;
   friend Value;