cmake: Check if compiler flags are supported before adding them

Author: rsomla1

cdk/cmake/platform.cmake

@@ -115,6 +115,17 @@ macro(add_flags LANG)
   set(CMAKE_${LANG}_FLAGS "${CMAKE_${LANG}_FLAGS}" PARENT_SCOPE)
 endmacro()
 
+include(CheckCXXCompilerFlag)
+
+# Set single compiler flag only if it is supported, ignore otherwise
+
+macro(set_compiler_flag FLAG)
+  unset(flag_supported CACHE)
+  CHECK_CXX_COMPILER_FLAG(${FLAG} flag_supported)
+  if(flag_supported)
+    add_compile_options(${FLAG})
+  endif()
+endmacro()
 
 # -----------------------------------------------------------------
 

cdk/extra/protobuf/CMakeLists.txt

@@ -96,20 +96,20 @@ set_visibility(hidden)
 
 if(GCC AND GCC VERSION_GREATER 11)
   # See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106199
-  add_compile_options(-Wno-stringop-overflow)
-  add_compile_options(-Wno-stringop-overread)
+  set_compiler_flag(-Wno-stringop-overflow)
+  set_compiler_flag(-Wno-stringop-overread)
 endif()
 
 if(NOT MSVC OR CLANG)
-  add_compile_options(-Wno-unused-const-variable)
+  set_compiler_flag(-Wno-unused-const-variable)
 endif()
 
 if(WIN32)
   add_compile_definitions(_CRT_SECURE_NO_WARNINGS _SCL_SECURE_NO_WARNINGS)
 endif()
 
 if(APPLE)
-  add_compile_options(-Wno-deprecated-declarations)
+  set_compiler_flag(-Wno-deprecated-declarations)
 endif()
 
 

cdk/extra/zlib/CMakeLists.txt

@@ -25,7 +25,7 @@ if(WIN32)
   # conformant name: _open. See online help for details.
 
   if(CLANG)
-    add_compile_options(-Wno-deprecated-declarations)
+    set_compiler_flag(-Wno-deprecated-declarations)
   else()
     add_compile_options(/wd4996)
   endif()

cdk/extra/zstd/CMakeLists.txt

@@ -22,7 +22,7 @@ endif()
 if(WIN32 AND CLANG)
   # This warning shows only when building with clang on Win (clang 18):
   # lib\compress\huf_compress.c(519,16): error : unused function 'HUF_isSorted'
-  add_compile_options(-Wno-unused-function)
+  set_compiler_flag(-Wno-unused-function)
 endif()
 
 

jdbc/CMakeLists.txt

@@ -215,10 +215,8 @@ if(NOT SHOW_JDBC_WARNINGS)
 
   else()
 
-    add_compile_options(
-      -Wno-unused-parameter
-      -Wno-deprecated-declarations
-    )
+    set_compiler_flag(-Wno-unused-parameter)
+    set_compiler_flag(-Wno-deprecated-declarations)
 
   endif()