Code Style

Lint
CheckStyle
FindBugs

Author: danielkutik

app/src/main/java/com/donnfelker/android/bootstrap/BootstrapApplication.java

@@ -10,23 +10,21 @@
 
 import com.github.kevinsawicki.http.HttpRequest;
 
-import dagger.ObjectGraph;
-
 /**
  * Android Bootstrap application
  */
 public class BootstrapApplication extends Application {
 
-    private static BootstrapApplication instance;
+    private static BootstrapApplication sInstance;
 
     /**
      * Create main application
      */
     public BootstrapApplication() {
-
         // Disable http.keepAlive on Froyo and below
-        if (SDK_INT <= FROYO)
+        if (SDK_INT <= FROYO) {
             HttpRequest.keepAlive(false);
+        }
     }
 
     /**
@@ -37,14 +35,13 @@ public BootstrapApplication() {
     public BootstrapApplication(final Context context) {
         this();
         attachBaseContext(context);
-
     }
 
     @Override
     public void onCreate() {
         super.onCreate();
 
-        instance = this;
+        sInstance = this;
 
         // Perform injection
         Injector.init(getRootModule(), this);
@@ -67,6 +64,6 @@ public BootstrapApplication(final Instrumentation instrumentation) {
     }
 
     public static BootstrapApplication getInstance() {
-        return instance;
+        return sInstance;
     }
 }

app/src/main/java/com/donnfelker/android/bootstrap/BootstrapModule.java

@@ -5,12 +5,10 @@
 
 import com.donnfelker.android.bootstrap.authenticator.BootstrapAuthenticatorActivity;
 import com.donnfelker.android.bootstrap.authenticator.LogoutService;
-import com.donnfelker.android.bootstrap.core.CheckIn;
 import com.donnfelker.android.bootstrap.core.TimerService;
 import com.donnfelker.android.bootstrap.ui.BootstrapTimerActivity;
 import com.donnfelker.android.bootstrap.ui.CarouselActivity;
 import com.donnfelker.android.bootstrap.ui.CheckInsListFragment;
-import com.donnfelker.android.bootstrap.ui.ItemListFragment;
 import com.donnfelker.android.bootstrap.ui.NewsActivity;
 import com.donnfelker.android.bootstrap.ui.NewsListFragment;
 import com.donnfelker.android.bootstrap.ui.UserActivity;

app/src/main/java/com/donnfelker/android/bootstrap/BootstrapServiceProvider.java

@@ -16,8 +16,8 @@
  */
 public class BootstrapServiceProvider {
 
-    @Inject ApiKeyProvider keyProvider;
-    @Inject UserAgentProvider userAgentProvider;
+    @Inject ApiKeyProvider mKeyProvider;
+    @Inject UserAgentProvider mUserAgentProvider;
 
     /**
      * Get service for configured key provider
@@ -29,6 +29,6 @@ public class BootstrapServiceProvider {
      * @throws AccountsException
      */
     public BootstrapService getService(Activity activity) throws IOException, AccountsException {
-        return new BootstrapService(keyProvider.getAuthKey(activity), userAgentProvider);
+        return new BootstrapService(mKeyProvider.getAuthKey(activity), mUserAgentProvider);
     }
 }

app/src/main/java/com/donnfelker/android/bootstrap/Injector.java

@@ -2,19 +2,16 @@
 
 import dagger.ObjectGraph;
 
-public final class Injector
-{
-    public static ObjectGraph objectGraph = null;
+public final class Injector {
+
+    public static ObjectGraph objectGraph = null;  //TODO why is this public?
 
 
     public static void init(final Object rootModule) {
 
-        if(objectGraph == null)
-        {
+        if(objectGraph == null) {
             objectGraph = ObjectGraph.create(rootModule);
-        }
-        else
-        {
+        } else {
             objectGraph = objectGraph.plus(rootModule);
         }
 
@@ -23,19 +20,16 @@ public static void init(final Object rootModule) {
 
     }
 
-    public static void init(final Object rootModule, final Object target)
-    {
+    public static void init(final Object rootModule, final Object target) {
         init(rootModule);
         inject(target);
     }
 
-    public static final void inject(final Object target)
-    {
+    public static void inject(final Object target) {
         objectGraph.inject(target);
     }
 
-    public static <T> T resolve(Class<T> type)
-    {
+    public static <T> T resolve(Class<T> type) {
         return objectGraph.get(type);
     }
 }

app/src/main/java/com/donnfelker/android/bootstrap/authenticator/AccountAuthenticatorService.java

@@ -9,18 +9,22 @@
 /**
  * Authenticator service that returns a subclass of AbstractAccountAuthenticator in onBind()
  */
-public class AccountAuthenticatorService extends Service {
+class AccountAuthenticatorService extends Service {
 
-    private static BootstrapAccountAuthenticator AUTHENTICATOR = null;
+    private static BootstrapAccountAuthenticator sAuthenticator = null;
 
     @Override
-    public IBinder onBind(Intent intent) {
-        return intent.getAction().equals(ACTION_AUTHENTICATOR_INTENT) ? getAuthenticator().getIBinder() : null;
+    public IBinder onBind(final Intent intent) {
+        if (intent != null && ACTION_AUTHENTICATOR_INTENT.equals(intent.getAction())) {
+            return getAuthenticator().getIBinder();
+        }
+        return null;
     }
 
     private BootstrapAccountAuthenticator getAuthenticator() {
-        if (AUTHENTICATOR == null)
-            AUTHENTICATOR = new BootstrapAccountAuthenticator(this);
-        return AUTHENTICATOR;
+        if (sAuthenticator == null) {
+            sAuthenticator = new BootstrapAccountAuthenticator(this);
+        }
+        return sAuthenticator;
     }
 }

app/src/main/java/com/donnfelker/android/bootstrap/authenticator/ApiKeyProvider.java

@@ -2,25 +2,26 @@
 
 package com.donnfelker.android.bootstrap.authenticator;
 
-import static android.accounts.AccountManager.KEY_AUTHTOKEN;
-
 import android.accounts.AccountManager;
 import android.accounts.AccountManagerFuture;
 import android.accounts.AccountsException;
 import android.app.Activity;
 import android.os.Bundle;
 
-import com.donnfelker.android.bootstrap.core.Constants;
+import java.io.IOException;
+
 import javax.inject.Inject;
 
-import java.io.IOException;
+import static android.accounts.AccountManager.KEY_AUTHTOKEN;
+import static com.donnfelker.android.bootstrap.core.Constants.Auth.AUTHTOKEN_TYPE;
+import static com.donnfelker.android.bootstrap.core.Constants.Auth.BOOTSTRAP_ACCOUNT_TYPE;
 
 /**
  * Bridge class that obtains a API key for the currently configured account
  */
 public class ApiKeyProvider {
 
-    @Inject AccountManager accountManager;
+    @Inject protected AccountManager mAccountManager;
 
     /**
      * This call blocks, so shouldn't be called on the UI thread
@@ -29,9 +30,10 @@ public class ApiKeyProvider {
      * @throws AccountsException
      * @throws IOException
      */
-    public String getAuthKey(Activity activity) throws AccountsException, IOException {
-        AccountManagerFuture<Bundle> accountManagerFuture = accountManager.getAuthTokenByFeatures(Constants.Auth.BOOTSTRAP_ACCOUNT_TYPE,
-                Constants.Auth.AUTHTOKEN_TYPE, new String[0], activity, null, null, null, null);
+    public String getAuthKey(final Activity activity) throws AccountsException, IOException {
+        final AccountManagerFuture<Bundle> accountManagerFuture
+                = mAccountManager.getAuthTokenByFeatures(BOOTSTRAP_ACCOUNT_TYPE,
+                        AUTHTOKEN_TYPE, new String[0], activity, null, null, null, null);
 
         return accountManagerFuture.getResult().getString(KEY_AUTHTOKEN);
     }

app/src/main/java/com/donnfelker/android/bootstrap/authenticator/BootstrapAccountAuthenticator.java

@@ -23,12 +23,12 @@ class BootstrapAccountAuthenticator extends AbstractAccountAuthenticator {
 
     private static final String DESCRIPTION_CLIENT = "Bootstrap for Android";
 
-    private final Context context;
+    private final Context mContext;
 
-    public BootstrapAccountAuthenticator(Context context) {
+    public BootstrapAccountAuthenticator(final Context context) {
         super(context);
 
-        this.context = context;
+        mContext = context;
     }
 
     /*
@@ -37,23 +37,28 @@ public BootstrapAccountAuthenticator(Context context) {
      * manager.
      */
     @Override
-    public Bundle addAccount(AccountAuthenticatorResponse response, String accountType, String authTokenType,
-            String[] requiredFeatures, Bundle options) throws NetworkErrorException {
-        final Intent intent = new Intent(context, BootstrapAuthenticatorActivity.class);
+    public Bundle addAccount(final AccountAuthenticatorResponse response, final String accountType,
+                             final String authTokenType, final String[] requiredFeatures,
+                             final Bundle options) throws NetworkErrorException {
+        final Intent intent = new Intent(mContext, BootstrapAuthenticatorActivity.class);
         intent.putExtra(PARAM_AUTHTOKEN_TYPE, authTokenType);
         intent.putExtra(KEY_ACCOUNT_AUTHENTICATOR_RESPONSE, response);
+
         final Bundle bundle = new Bundle();
         bundle.putParcelable(KEY_INTENT, intent);
+
         return bundle;
     }
 
     @Override
-    public Bundle confirmCredentials(AccountAuthenticatorResponse response, Account account, Bundle options) {
+    public Bundle confirmCredentials(final AccountAuthenticatorResponse response,
+                                     final Account account, final Bundle options) {
         return null;
     }
 
     @Override
-    public Bundle editProperties(AccountAuthenticatorResponse response, String accountType) {
+    public Bundle editProperties(final AccountAuthenticatorResponse response,
+                                 final String accountType) {
         return null;
     }
 
@@ -69,35 +74,39 @@ public Bundle editProperties(AccountAuthenticatorResponse response, String accou
      * @throws NetworkErrorException
      */
     @Override
-    public Bundle getAuthToken(AccountAuthenticatorResponse response, Account account, String authTokenType,
-            Bundle options) throws NetworkErrorException {
+    public Bundle getAuthToken(final AccountAuthenticatorResponse response,
+                               final Account account, final String authTokenType,
+                               final Bundle options) throws NetworkErrorException {
 
         Ln.d("Attempting to get authToken");
 
-        String authToken = AccountManager.get(context).peekAuthToken(account, authTokenType);
-        Bundle bundle = new Bundle();
+        final String authToken = AccountManager.get(mContext).peekAuthToken(account, authTokenType);
+
+        final Bundle bundle = new Bundle();
         bundle.putString(KEY_ACCOUNT_NAME, account.name);
         bundle.putString(KEY_ACCOUNT_TYPE, Constants.Auth.BOOTSTRAP_ACCOUNT_TYPE);
         bundle.putString(KEY_AUTHTOKEN, authToken);
+
         return bundle;
     }
 
     @Override
-    public String getAuthTokenLabel(String authTokenType) {
+    public String getAuthTokenLabel(final String authTokenType) {
         return authTokenType.equals(Constants.Auth.AUTHTOKEN_TYPE) ? authTokenType : null;
     }
 
     @Override
-    public Bundle hasFeatures(AccountAuthenticatorResponse response, Account account, String[] features)
-            throws NetworkErrorException {
+    public Bundle hasFeatures(final AccountAuthenticatorResponse response, final Account account,
+                              final String[] features) throws NetworkErrorException {
         final Bundle result = new Bundle();
         result.putBoolean(KEY_BOOLEAN_RESULT, false);
         return result;
     }
 
     @Override
-    public Bundle updateCredentials(AccountAuthenticatorResponse response, Account account, String authTokenType,
-            Bundle options) {
+    public Bundle updateCredentials(final AccountAuthenticatorResponse response,
+                                    final Account account, final String authTokenType,
+                                    final Bundle options) {
         return null;
     }
 }