Skip to content

Commit 91b270b

Browse files
committed
fixed issue with Observable, ContentObserver, DataSetObserver, and removed unnecessary classes
1 parent 6513adf commit 91b270b

21 files changed

+58
-2241
lines changed

src/example/SQLDemoActivity.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,14 @@ public void onCreate(Bundle savedInstanceState) {
2626
//then you can open the database using a password
2727
SQLiteDatabase db = eventsData.getWritableDatabase(password);
2828

29-
addEvent("Hello Android Event", password);
30-
Cursor cursor = getEvents(password);
29+
for (int i = 1; i < 100; i++)
30+
addEvent("Hello Android Event: " + i, db);
31+
32+
db.close();
33+
34+
db = eventsData.getReadableDatabase(password);
35+
36+
Cursor cursor = getEvents(db);
3137
showEvents(cursor);
3238

3339
db.close();
@@ -39,20 +45,15 @@ public void onDestroy() {
3945
eventsData.close();
4046
}
4147

42-
private void addEvent(String title, String password) {
43-
SQLiteDatabase db = eventsData.getWritableDatabase(password);
48+
private void addEvent(String title, SQLiteDatabase db) {
4449

4550
ContentValues values = new ContentValues();
4651
values.put(EventDataSQLHelper.TIME, System.currentTimeMillis());
4752
values.put(EventDataSQLHelper.TITLE, title);
4853
db.insert(EventDataSQLHelper.TABLE, null, values);
49-
5054
}
5155

52-
private Cursor getEvents(String password) {
53-
SQLiteDatabase db = eventsData.getReadableDatabase(password);
54-
55-
56+
private Cursor getEvents(SQLiteDatabase db) {
5657

5758
Cursor cursor = db.query(EventDataSQLHelper.TABLE, null, null, null, null,
5859
null, null);

src/info/guardianproject/database/AbstractCursor.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222

2323
import android.content.ContentResolver;
2424
import android.database.CharArrayBuffer;
25+
import android.database.ContentObservable;
26+
import android.database.DataSetObservable;
27+
import android.database.DataSetObserver;
28+
import android.database.ContentObserver;
2529
import android.net.Uri;
2630
import android.os.Bundle;
2731
import android.util.Config;
@@ -32,7 +36,7 @@
3236
* This is an abstract cursor class that handles a lot of the common code
3337
* that all cursors need to deal with and is provided for convenience reasons.
3438
*/
35-
public abstract class AbstractCursor implements CrossProcessCursor {
39+
public abstract class AbstractCursor implements android.database.CrossProcessCursor {
3640
private static final String TAG = "Cursor";
3741

3842
DataSetObservable mDataSetObservable = new DataSetObservable();
@@ -79,7 +83,7 @@ public void deactivate() {
7983
*/
8084
public void deactivateInternal() {
8185
if (mSelfObserver != null) {
82-
// mContentResolver.unregisterContentObserver(mSelfObserver);
86+
mContentResolver.unregisterContentObserver(mSelfObserver);
8387
mSelfObserverRegistered = false;
8488
}
8589
mDataSetObservable.notifyInvalidated();
@@ -88,7 +92,7 @@ public void deactivateInternal() {
8892
public boolean requery() {
8993
if (mSelfObserver != null && mSelfObserverRegistered == false) {
9094

91-
// mContentResolver.registerContentObserver(mNotifyUri, true, mSelfObserver);
95+
mContentResolver.registerContentObserver(mNotifyUri, true, mSelfObserver);
9296
mSelfObserverRegistered = true;
9397
}
9498
mDataSetObservable.notifyChanged();
@@ -200,7 +204,7 @@ public final boolean moveToPosition(int position) {
200204
* @param position start position of data
201205
* @param window
202206
*/
203-
public void fillWindow(int position, CursorWindow window) {
207+
public void fillWindow(int position, android.database.CursorWindow window) {
204208
if (position < 0 || position > getCount()) {
205209
return;
206210
}
@@ -608,6 +612,7 @@ public void onChange(boolean selfChange) {
608612
cursor.onChange(false);
609613
}
610614
}
615+
611616
}
612617

613618
/**

src/info/guardianproject/database/BulkCursorToCursorAdaptor.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,16 @@
1616

1717
package info.guardianproject.database;
1818

19+
import java.util.Map;
20+
1921
import android.database.CharArrayBuffer;
2022
import android.database.ContentObserver;
2123
import android.database.DataSetObserver;
22-
import android.os.RemoteException;
24+
2325
import android.os.Bundle;
26+
import android.os.RemoteException;
2427
import android.util.Log;
2528

26-
import java.util.Map;
27-
2829
/**
2930
* Adapts an {@link IBulkCursor} to a {@link Cursor} for use in the local
3031
* process.
@@ -89,7 +90,7 @@ public synchronized IContentObserver getObserver() {
8990
if (mObserverBridge == null) {
9091
mObserverBridge = new SelfContentObserver(this);
9192
}
92-
return mObserverBridge.getContentObserver();
93+
return null;//mObserverBridge.getContentObserver(); //TODO nf fix this
9394
}
9495

9596
@Override

src/info/guardianproject/database/ContentObservable.java

Lines changed: 0 additions & 56 deletions
This file was deleted.

src/info/guardianproject/database/ContentObserver.java

Lines changed: 0 additions & 133 deletions
This file was deleted.

src/info/guardianproject/database/CrossProcessCursor.java

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)