Skip to content

Commit 00a4030

Browse files
committed
Suggest resolving conflicts by adding new commits vs amending the merge commit
This gives us slightly messier git history, but more importantly makes reviewing substantially easier.
1 parent 677790f commit 00a4030

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/update-release-branch.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ def open_pr(
8888
body.append('')
8989
body.append('Please review the following:')
9090
if len(conflicted_files) > 0:
91-
body.append(' - [ ] You have amended the merge commit appearing in this branch to resolve ' +
92-
'the merge conflicts in the following files:')
91+
body.append(' - [ ] You have added commits to this branch that resolve the merge conflicts ' +
92+
'in the following files:')
9393
body.extend([f' - [ ] `{file}`' for file in conflicted_files])
94+
body.append(' - [ ] Another maintainer has reviewed the additional commits you added to this ' +
95+
'branch to resolve the merge conflicts.')
9496
body.append(' - [ ] The CHANGELOG displays the correct version and date.')
9597
body.append(' - [ ] The CHANGELOG includes all relevant, user-facing changes since the last release.')
9698
body.append(' - [ ] There are no unexpected commits being merged into the ' + target_branch + ' branch.')

0 commit comments

Comments
 (0)