Skip to content

On Fatfs time zone is ignored on file time #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luc-github opened this issue Sep 29, 2017 · 9 comments
Closed

On Fatfs time zone is ignored on file time #679

luc-github opened this issue Sep 29, 2017 · 9 comments

Comments

@luc-github
Copy link
Contributor

luc-github commented Sep 29, 2017

Hi when using fatfs function f_stat to get last access date/time I found time zone is ignored and only UTC time is given

I did a script to show issue on SD : https://gist.github.com/luc-github/9124cbb2b1e0ed0b3696b4e6223b8e6e

@luc-github
Copy link
Contributor Author

After investigation it seems the function to get timestamp in libfatfs : get_fattime
use gmtime instead of localtime_r but this part is in IDF

@me-no-dev
Copy link
Member

you can submit an issue or pr there :) those are looked at and taken care of as well :)

@luc-github
Copy link
Contributor Author

Yes I am currently setting up the environnement to compile IDF to test first - so I will be able to do PR 😄

@me-no-dev
Copy link
Member

put arduino as component and set up under sloeber/eclipse :) you might like it

@luc-github
Copy link
Contributor Author

Ok will try it thank you- I get used to geany (http://www.geany.org/) which is a light cross platform code editor

@me-no-dev
Copy link
Member

sure :D whatever floats your boat :P

@luc-github
Copy link
Contributor Author

luc-github commented Sep 30, 2017

I cannot for some unknown reason compile using arduino-esp32 as ESP-IDF component but was able to get modified libfatfs.a and replaced arduino-esp32 one
and it works !!! so fix is confirmed, I will do PR on IDF later

@luc-github
Copy link
Contributor Author

luc-github commented Sep 30, 2017

PR done espressif/esp-idf#1055

@luc-github
Copy link
Contributor Author

wow seems this issue is still open - I close it sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants