Skip to content

Commit 13f572e

Browse files
mikelehenwilhuff
authored andcommitted
Increase expectation timeout to 25 seconds. (#744)
I'm doing this to: 1) Experimentally see if it improves the flakiness we've been seeing in the Query Conformance Tests. 2) Insulate us from the fact that GRPC seems to take a /minimum/ of 10 seconds to reconnect (at least in some cases) after a connection failure. I've opened b/72864027 to revisit this in the future.
1 parent 47d81fd commit 13f572e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

Firestore/Example/Tests/Util/XCTestCase+Await.mm

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818

1919
#import <Foundation/Foundation.h>
2020

21-
static const double kExpectationWaitSeconds = 10.0;
21+
// TODO(b/72864027): Reduce this to 10 seconds again once we've resolved issues with Query
22+
// Conformance Tests flakiness or gotten answers from GRPC about reconnect delays.
23+
static const double kExpectationWaitSeconds = 25.0;
2224

2325
@implementation XCTestCase (Await)
2426

0 commit comments

Comments
 (0)