Remove usages of "whitelist" in Firestore. (#6846)

Fixes #6755.

Author: wilhuff

Firestore/core/src/remote/datastore.cc

@@ -82,8 +82,8 @@ void LogGrpcCallFinished(absl::string_view rpc_name,
             status.error_message());
   if (LogIsDebugEnabled()) {
     auto headers =
-        Datastore::GetWhitelistedHeadersAsString(call->GetResponseHeaders());
-    LOG_DEBUG("RPC %s returned headers (whitelisted): %s", rpc_name, headers);
+        Datastore::GetAllowlistedHeadersAsString(call->GetResponseHeaders());
+    LOG_DEBUG("RPC %s returned headers (allowlisted): %s", rpc_name, headers);
   }
 }
 
@@ -332,15 +332,15 @@ bool Datastore::IsPermanentWriteError(const Status& error) {
   return IsPermanentError(error) && !IsAbortedError(error);
 }
 
-std::string Datastore::GetWhitelistedHeadersAsString(
+std::string Datastore::GetAllowlistedHeadersAsString(
     const GrpcCall::Metadata& headers) {
-  static std::unordered_set<std::string> whitelist = {
+  static std::unordered_set<std::string> allowlist = {
       "date", "x-google-backends", "x-google-netmon-label", "x-google-service",
       "x-google-gfe-request-trace"};
 
   std::string result;
   for (const auto& kv : headers) {
-    if (whitelist.find(MakeString(kv.first)) != whitelist.end()) {
+    if (allowlist.find(MakeString(kv.first)) != allowlist.end()) {
       absl::StrAppend(&result, MakeStringView(kv.first), ": ",
                       MakeStringView(kv.second), "\n");
     }

Firestore/core/src/remote/datastore.h

@@ -123,7 +123,7 @@ class Datastore : public std::enable_shared_from_this<Datastore> {
    */
   static bool IsPermanentWriteError(const util::Status& status);
 
-  static std::string GetWhitelistedHeadersAsString(
+  static std::string GetAllowlistedHeadersAsString(
       const GrpcCall::Metadata& headers);
 
   Datastore(const Datastore& other) = delete;
@@ -169,7 +169,7 @@ class Datastore : public std::enable_shared_from_this<Datastore> {
 
   void RemoveGrpcCall(GrpcCall* to_remove);
 
-  static GrpcCall::Metadata ExtractWhitelistedHeaders(
+  static GrpcCall::Metadata ExtractAllowlistedHeaders(
       const GrpcCall::Metadata& headers);
 
   // In case Auth tries to invoke a callback after `Datastore` has been shut

Firestore/core/src/remote/stream.cc

@@ -202,8 +202,8 @@ void Stream::OnStreamRead(const grpc::ByteBuffer& message) {
   HARD_ASSERT(IsStarted(), "OnStreamRead called for a stopped stream.");
 
   if (LogIsDebugEnabled()) {
-    LOG_DEBUG("%s headers (whitelisted): %s", GetDebugDescription(),
-              Datastore::GetWhitelistedHeadersAsString(
+    LOG_DEBUG("%s headers (allowlisted): %s", GetDebugDescription(),
+              Datastore::GetAllowlistedHeadersAsString(
                   grpc_stream_->GetResponseHeaders()));
   }
 

Firestore/core/test/unit/remote/datastore_test.cc

@@ -176,17 +176,17 @@ TEST_F(DatastoreTest, CanShutdownWithNoOperations) {
   Shutdown();
 }
 
-TEST_F(DatastoreTest, WhitelistedHeaders) {
+TEST_F(DatastoreTest, AllowlistedHeaders) {
   GrpcStream::Metadata headers = {
       {"date", "date value"},
       {"x-google-backends", "backend value"},
-      {"x-google-foo", "should not be in result"},  // Not whitelisted
+      {"x-google-foo", "should not be in result"},  // Not allowlisted
       {"x-google-gfe-request-trace", "request trace"},
       {"x-google-netmon-label", "netmon label"},
       {"x-google-service", "service 1"},
       {"x-google-service", "service 2"},  // Duplicate names are allowed
   };
-  std::string result = Datastore::GetWhitelistedHeadersAsString(headers);
+  std::string result = Datastore::GetAllowlistedHeadersAsString(headers);
   EXPECT_EQ(result,
             "date: date value\n"
             "x-google-backends: backend value\n"