Firebase App Check One-time Use Tokens for Callable Functions SDK - #11270
Merged
Conversation
Member
|
I've since updated the proposal with the latest revision. Introducing a new public |
ryanwilson
reviewed
May 12, 2023
paulb777
reviewed
May 12, 2023
ncooke3
force-pushed
the
callableFunctions
branch
from
May 12, 2023 18:15
2b591cd to
bb8df26
Compare
Contributor
Apple API Diff ReportCommit: 00b8926 [BUILD ERROR] FirebaseFunctions |
andrewheard
approved these changes
May 15, 2023
andrewheard
left a comment
andrewheard
left a comment
Contributor
There was a problem hiding this comment.
LGTM! My suggestions are all extremely nitpicky, feel free to ignore.
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
Co-authored-by: Andrew Heard <andrewheard@google.com>
weixifan
reviewed
May 16, 2023
andrewheard
added a commit
that referenced
this pull request
May 16, 2023
Potential fix for #11270 (comment)
Updated `limitedUseTokenWithCompletion:` to always return a fresh limited-used token in every invocation (removed the `ongoingLimitedUseTokenPromise` property).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Testing
API Changes