Skip to content

[Vertex AI] Refactor HarmCategory enum - #13686

Merged
andrewheard merged 5 commits into
vertexai-releasefrom
ah/vertex-harmcategory
Sep 23, 2024
Merged

[Vertex AI] Refactor HarmCategory enum#13686
andrewheard merged 5 commits into
vertexai-releasefrom
ah/vertex-harmcategory

Conversation

@andrewheard

@andrewheard andrewheard commented Sep 20, 2024

Copy link
Copy Markdown
Contributor
  • Removed the unspecified case from HarmCategory since it should never be returned by the backend and should never be provided in a request.
    • The unknown case would cover this anomalous scenario if it ever occurred.
  • Moved the HarmCategory enum out of SafetySetting since it is also used in SafetyRating.

@andrewheard andrewheard added this to the 11.4.0 - M154.1 milestone Sep 20, 2024
@andrewheard
andrewheard marked this pull request as ready for review September 20, 2024 18:33
Comment thread FirebaseVertexAI/CHANGELOG.md Outdated
@andrewheard
andrewheard force-pushed the ah/vertex-harmcategory branch from b81e68f to aa4058c Compare September 23, 2024 14:39
@andrewheard

Copy link
Copy Markdown
Contributor Author

Rebased vertexai-release on main to grab the CI changes in #13687.

@andrewheard
andrewheard merged commit 1151a7f into vertexai-release Sep 23, 2024
@andrewheard
andrewheard deleted the ah/vertex-harmcategory branch September 23, 2024 14:53
andrewheard added a commit that referenced this pull request Sep 24, 2024
# Conflicts:
#	FirebaseVertexAI/CHANGELOG.md
@firebase firebase locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants