Skip to content

Add custom signals support in Remote Config. - #13976

Merged
ncooke3 merged 24 commits into
mainfrom
nc/custom-signal
Jan 7, 2025
Merged

Add custom signals support in Remote Config.#13976
ncooke3 merged 24 commits into
mainfrom
nc/custom-signal

Conversation

@tusharkhandelwal8

@tusharkhandelwal8 tusharkhandelwal8 commented Oct 27, 2024

Copy link
Copy Markdown
Contributor

feat(rc): Add method to set custom signals for Remote Config Custom targeting

@github-actions

github-actions Bot commented Oct 27, 2024

Copy link
Copy Markdown
Contributor

Apple API Diff Report

Commit: 005e4b8
Last updated: Tue Jan 7 09:21 PST 2025
View workflow logs & download artifacts


FirebaseRemoteConfig

Classes

FIRRemoteConfig
[ADDED] -setCustomSignals:withCompletion:
Objective-C:
+  - ( void ) setCustomSignals :( nonnull NSDictionary < NSString * , NSObject *> * ) customSignals withCompletion :( void ( ^ _Nullable )( NSError * _Nullable error )) completionHandler NS_REFINED_FOR_SWIFT ;

Constants

[ADDED] FIRRemoteConfigCustomSignalsErrorDomain
[ADDED] FIRRemoteConfigCustomSignalsErrorDomain
Swift:
+  let RemoteConfigCustomSignalsErrorDomain : String
Objective-C:
+  extern NS_SWIFT_NAME ( RemoteConfigCustomSignalsErrorDomain ) NSString * const FIRRemoteConfigCustomSignalsErrorDomain

Enumerations

[ADDED] FIRRemoteConfigCustomSignalsError
[ADDED] FIRRemoteConfigCustomSignalsError
Swift:
+  typealias RemoteConfigCustomSignalsError . Code . _ErrorType = RemoteConfigCustomSignalsError
+    case unknown = 8101
+    case invalidValueType = 8102
+    case limitExceeded = 8103
Objective-C:
+  enum FIRRemoteConfigCustomSignalsError : NSInteger {}
+    FIRRemoteConfigCustomSignalsErrorUnknown = 8101
+    FIRRemoteConfigCustomSignalsErrorInvalidValueType = 8102
+    FIRRemoteConfigCustomSignalsErrorLimitExceeded = 8103

Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated
Comment thread FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m Outdated
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated
@tusharkhandelwal8
tusharkhandelwal8 marked this pull request as ready for review November 7, 2024 11:19
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated
Comment thread FirebaseRemoteConfig/Sources/FIRRemoteConfig.m Outdated

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tusharkhandelwal8 Thanks for working through all the feedback. LGTM!

Comment thread FirebaseRemoteConfig/Swift/CustomSignals.swift

@ncooke3 ncooke3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3
ncooke3 merged commit 15179e4 into main Jan 7, 2025
@ncooke3
ncooke3 deleted the nc/custom-signal branch January 7, 2025 20:55
@firebase firebase locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants