Skip to content

Disable use of $httpHeaders in Cordova #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 13, 2020
Merged

Disable use of $httpHeaders in Cordova #2626

merged 3 commits into from
Feb 13, 2020

Conversation

thebrianchen
Copy link

Fixes #2586

@thebrianchen thebrianchen self-assigned this Feb 13, 2020
@thebrianchen thebrianchen requested a review from wilhuff February 13, 2020 22:15
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Feb 13, 2020
wilhuff
wilhuff approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Feb 13, 2020
@thebrianchen thebrianchen merged commit fde2314 into master Feb 13, 2020
@thebrianchen thebrianchen deleted the bc/cordova branch February 13, 2020 23:04
@firebase firebase locked and limited conversation to collaborators Mar 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wilhuff wilhuff wilhuff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thebrianchen thebrianchen

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Firestore Auth does not work in Cordova

2 participants

@thebrianchen @wilhuff