Skip to content

Commit adff5e9

Browse files
committed
updated readme info, fixed key changes to notes below
1 parent 382244e commit adff5e9

File tree

2 files changed

+21
-23
lines changed

2 files changed

+21
-23
lines changed

README.md

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -404,22 +404,22 @@ If no denominator is given, it will default to the next power of two
404404
(so 3:4, 5:8, 7:8, 11:16).
405405
So in other words if you need a 5:6, you'll need to write t5:6. :)
406406
The ratio of the beat saves. You only need to specify it once per group.
407-
For nested tripets, group those by adding an extra 't'.
407+
For nested tripets, group those by adding an extra 'T'.
408408

409409
Consider the 2 tracks:
410410

411411
```
412-
1 1t
413-
2 2t
414-
3 3t
412+
1 1T
413+
2 2T
414+
3 3T
415415
4
416-
1 1t
417-
2 2t
418-
3 3t
416+
1 1T
417+
2 2T
418+
3 3T
419419
4
420420
```
421421

422-
The spacing is not even between the sets, but the 't' value stretches them
422+
The spacing is not even between the sets, but the 'T' value stretches them
423423
to make them line up in a default ratio of 3:4.
424424

425425
## Picking
@@ -428,25 +428,21 @@ to make them line up in a default ratio of 3:4.
428428

429429
## Key changes
430430

431-
The following behavior is optional and probably not useful to many musicians.
432-
433-
However, beginners may find inspiration by picking a scale instead of using
434-
sharps and flats.
431+
```
432+
# change key (this will change the key of the current scale to 3 (E))
433+
%k=3
435434
436-
The current scale is currently accessible as a global variable (this will be per-track soon).
435+
# to set a relative key, this will go from a major scale to relative minor scale
436+
%k+6
437437
438-
To set the notes to match scale,
438+
# you can also go down to relative minor below
439+
%k-6
439440
440-
```
441-
# set notes to dorian mode (won't change key)
441+
# scale names are supported, this changes the scale shape to dorian
442442
%s=dorian
443443
444-
# rotate/relative scale (will move the key note)
445-
%r=dorian
446-
447-
# in either case, you can also use mode numbers
444+
# you can also use mode numbers
448445
%s=2
449-
%r=2
450446
```
451447

452448
## Chords (Advanced)

src/player.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,12 +379,14 @@ def run(self):
379379
# self.octave += -1*sgn(self.transpose)*(self.transpose//12)
380380
# self.transpose = self.transpose%12
381381
elif op=='-':
382-
if var=='K': self.transpose -= note_offset('#1' if val=='-' else val)
382+
if var=='K':
383+
self.transpose -= note_offset(val)
384+
print(note_offset(val))
383385
elif var=='O': self.octave -= int(1 if val=='-' else val)
384386
elif var=='T': self.tempo -= max(0,float(val))
385387
elif var in 'GX': self.grid -= max(0,float(val))
386388
else: assert False
387-
self.octave += -1*sgn(self.transpose)*(self.transpose//12)
389+
# self.octave += -1*sgn(self.transpose)*(self.transpose//12)
388390
# if var=='K':
389391
# self.octave += -1*sgn(self.transpose)*(self.transpose//12)
390392
# self.transpose = self.transpose%12

0 commit comments

Comments
 (0)