-
Notifications
You must be signed in to change notification settings - Fork 29.4k
Comparing changes
Open a pull request
base repository: flutter/flutter
base: a873a27309b0
head repository: flutter/flutter
compare: cbec6e9846b7
- 15 commits
- 195 files changed
- 15 contributors
Commits on Oct 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 918767a - Browse repository at this point
Copy the full SHA 918767aView commit details -
Fix crash when NSAttributedString is passed to insertText on macOS (#…
…176329) ## Description This PR fixes a crash in the macOS text input plugin that occurs when `NSAttributedString` is passed to the `insertText:replacementRange:` method instead of `NSString`. ### Root Cause The `insertText:replacementRange:` method of `NSTextInputClient` protocol can receive either `NSString` or `NSAttributedString`. The previous implementation directly called `UTF8String` on the input parameter without type checking. Since `NSAttributedString` doesn't respond to the `UTF8String` selector, this caused a crash with the error: -[NSConcreteMutableAttributedString UTF8String]: unrecognized selector sent to instance ### Changes Made - Added type checking to determine if the input is `NSAttributedString` - Extract the underlying `NSString` using `[string string]` before calling `UTF8String` - This follows the same pattern already implemented in the `setMarkedText:selectedRange:replacementRange:` method in the same file ### Crash Stack Trace Thread 0 Crashed: 0 CoreFoundation __exceptionPreprocess 1 libobjc.A.dylib objc_exception_throw 2 CoreFoundation -[NSObject(NSObject) doesNotRecognizeSelector:] 3 FlutterMacOS -[FlutterTextInputPlugin insertText:replacementRange:] (FlutterTextInputPlugin.mm:784) 4 AppKit -[NSTextInputContext(NSInputContext_WithCompletion) insertText:replacementRange:completionHandler:] ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Kim Ki Cheol <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4119c70 - Browse repository at this point
Copy the full SHA 4119c70View commit details -
Add textfield prop to SearchAnchor (#174497)
This PR adds support for configuring smartQuotesType and smartDashesType in SearchAnchor. These values are passed down to the inner TextField, allowing developers to control smart quotes and smart dashes behavior consistently when using SearchAnchor fixes: #174509 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for 8e164a5 - Browse repository at this point
Copy the full SHA 8e164a5View commit details -
Manual roll Dart SDK from 2d8e0359a767 to 25b6094026e4 (5 revisions) (#…
…177109) Manual roll requested by [email protected] https://dart.googlesource.com/sdk.git/+log/2d8e0359a767..25b6094026e4 2025-10-14 [email protected] Version 3.11.0-22.0.dev 2025-10-14 [email protected] Version 3.11.0-21.0.dev 2025-10-14 [email protected] Version 3.11.0-20.0.dev 2025-10-13 [email protected] Version 3.11.0-19.0.dev 2025-10-13 [email protected] Version 3.11.0-18.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 9767094 - Browse repository at this point
Copy the full SHA 9767094View commit details -
Revert "Resolve resolve native Flutter dependencies in Android Studio (…
…#167332)" (#177053) This reverts commit 0c0406a. Fixes #177037 I am leaving the method for checking if the build was launched from android studio. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for eb325fc - Browse repository at this point
Copy the full SHA eb325fcView commit details -
[Gradle 9] Resolve Gradle 9 Deprecations in flutter/flutter part 1 (#…
…176865) Resolving Gradle 9 deprecations in integration tests and tooling. Basically any Android project that is not in the engine. I had to bump AGP to 8.11.0 (and subsequently bump gradle and KGP) because lower versions include features that are deprecated in Gradle 9. Partially Addresses #173321 Partially Addresses #173318 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for a9866bc - Browse repository at this point
Copy the full SHA a9866bcView commit details -
Make sure that an InkResponse doesn't crash in 0x0 environment (#175426)
This is my attempt to handle #6537 for the InkResponse widget.
Configuration menu - View commit details
-
Copy full SHA for 71d49b1 - Browse repository at this point
Copy the full SHA 71d49b1View commit details -
Fix typo in ButtonBar documentation (#177078)
Changed "replace" to "replaced" _[ButtonBar] has been **replaced** by a more efficient widget, [OverflowBar]._ ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
Configuration menu - View commit details
-
Copy full SHA for 66913c2 - Browse repository at this point
Copy the full SHA 66913c2View commit details -
Make sure that a SubmenuButton doesn't crash in 0x0 environment (#176535
) This is my attempt to handle #6537 for the SubmenuButton widget.
Configuration menu - View commit details
-
Copy full SHA for 4f7d265 - Browse repository at this point
Copy the full SHA 4f7d265View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd2b1bc - Browse repository at this point
Copy the full SHA fd2b1bcView commit details
Commits on Oct 17, 2025
-
Make sure that a MenuAcceleratorLabel doesn't crash in 0x0 environment (
#176646) This is my attempt to handle #6537 for the MenuAcceleratorLabel widget. Co-authored-by: Tong Mu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 180c5b6 - Browse repository at this point
Copy the full SHA 180c5b6View commit details -
Manual roll Dart to a4485e5ef821 (3.11.0-25.0.dev) (#177132)
Includes migration from dart/runtime/bin:dart_io_api to common_embedder_dart_io
Configuration menu - View commit details
-
Copy full SHA for a14c7fe - Browse repository at this point
Copy the full SHA a14c7feView commit details -
Roll Fuchsia Linux SDK from _dd0Jv50H0oUI2Ad8... to ZHuhfPyyV-LcKDLRh…
…... (#177137) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 5187246 - Browse repository at this point
Copy the full SHA 5187246View commit details -
Tapping outside of
SelectableRegion
should dismiss the selection (#……176843) This PR updates selectable region so it dismisses the selection when a tap happens outside of it. This is done through the use of `TapRegion` and it's `onTapOutside` callback. https://github.com/user-attachments/assets/d5678c85-9d04-4c9c-af16-9a09a001c228 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Renzo Olivares <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2f110cc - Browse repository at this point
Copy the full SHA 2f110ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbec6e9 - Browse repository at this point
Copy the full SHA cbec6e9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff a873a27309b0...cbec6e9846b7