Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a873a27309b0
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cbec6e9846b7
Choose a head ref
  • 15 commits
  • 195 files changed
  • 15 contributors

Commits on Oct 16, 2025

  1. Correct basque time format (#177031)

    Fixes #176677
    justinmc authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    918767a View commit details
    Browse the repository at this point in the history
  2. Fix crash when NSAttributedString is passed to insertText on macOS (#…

    …176329)
    
    ## Description
    
    This PR fixes a crash in the macOS text input plugin that occurs when
    `NSAttributedString` is passed to the `insertText:replacementRange:`
    method instead of `NSString`.
    
    ### Root Cause
    
    The `insertText:replacementRange:` method of `NSTextInputClient`
    protocol can receive either `NSString` or `NSAttributedString`. The
    previous implementation directly called `UTF8String` on the input
    parameter without type checking. Since `NSAttributedString` doesn't
    respond to the `UTF8String` selector, this caused a crash with the
    error:
    
    -[NSConcreteMutableAttributedString UTF8String]: unrecognized selector
    sent to instance
    
    ### Changes Made
    - Added type checking to determine if the input is `NSAttributedString`
    - Extract the underlying `NSString` using `[string string]` before
    calling `UTF8String`
    - This follows the same pattern already implemented in the
    `setMarkedText:selectedRange:replacementRange:` method in the same file
    
    ### Crash Stack Trace
    
    Thread 0 Crashed: 0 CoreFoundation __exceptionPreprocess 1
    libobjc.A.dylib objc_exception_throw 2 CoreFoundation
    -[NSObject(NSObject) doesNotRecognizeSelector:] 3 FlutterMacOS
    -[FlutterTextInputPlugin insertText:replacementRange:]
    (FlutterTextInputPlugin.mm:784) 4 AppKit
    -[NSTextInputContext(NSInputContext_WithCompletion)
    insertText:replacementRange:completionHandler:]
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Kim Ki Cheol <[email protected]>
    Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
    3 people authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    4119c70 View commit details
    Browse the repository at this point in the history
  3. Add textfield prop to SearchAnchor (#174497)

    This PR adds support for configuring smartQuotesType and smartDashesType
    in SearchAnchor. These values are passed down to the inner TextField,
    allowing developers to control smart quotes and smart dashes behavior
    consistently when using SearchAnchor
    
    fixes: #174509 
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    progamax authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    8e164a5 View commit details
    Browse the repository at this point in the history
  4. Manual roll Dart SDK from 2d8e0359a767 to 25b6094026e4 (5 revisions) (#…

    …177109)
    
    Manual roll requested by [email protected]
    
    https://dart.googlesource.com/sdk.git/+log/2d8e0359a767..25b6094026e4
    
    2025-10-14 [email protected]
    Version 3.11.0-22.0.dev
    2025-10-14 [email protected]
    Version 3.11.0-21.0.dev
    2025-10-14 [email protected]
    Version 3.11.0-20.0.dev
    2025-10-13 [email protected]
    Version 3.11.0-19.0.dev
    2025-10-13 [email protected]
    Version 3.11.0-18.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC [email protected],[email protected],[email protected]
    on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    9767094 View commit details
    Browse the repository at this point in the history
  5. Revert "Resolve resolve native Flutter dependencies in Android Studio (

    …#167332)" (#177053)
    
    This reverts commit 0c0406a.
    Fixes #177037
    
    I am leaving the method for checking if the build was launched from
    android studio.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    reidbaker authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    eb325fc View commit details
    Browse the repository at this point in the history
  6. [Gradle 9] Resolve Gradle 9 Deprecations in flutter/flutter part 1 (#…

    …176865)
    
    Resolving Gradle 9 deprecations in integration tests and tooling.
    Basically any Android project that is not in the engine.
    
    I had to bump AGP to 8.11.0 (and subsequently bump gradle and KGP)
    because lower versions include features that are deprecated in Gradle 9.
    
    Partially Addresses #173321
    Partially Addresses #173318
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    jesswrd authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    a9866bc View commit details
    Browse the repository at this point in the history
  7. Make sure that an InkResponse doesn't crash in 0x0 environment (#175426)

    This is my attempt to handle
    #6537 for the InkResponse
    widget.
    ahmedsameha1 authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    71d49b1 View commit details
    Browse the repository at this point in the history
  8. Fix typo in ButtonBar documentation (#177078)

    Changed "replace" to "replaced"
    
    _[ButtonBar] has been **replaced** by a more efficient widget,
    [OverflowBar]._
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.
    leuchte authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    66913c2 View commit details
    Browse the repository at this point in the history
  9. Make sure that a SubmenuButton doesn't crash in 0x0 environment (#176535

    )
    
    This is my attempt to handle
    #6537 for the SubmenuButton
    widget.
    ahmedsameha1 authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    4f7d265 View commit details
    Browse the repository at this point in the history
  10. Make sure that a NavigationRail doesn't crash in 0x0 environment (#17…

    …7022)
    
    This is my attempt to handle
    #6537 for the NavigationRail
    widget.
    ahmedsameha1 authored Oct 16, 2025
    Configuration menu
    Copy the full SHA
    fd2b1bc View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2025

  1. Make sure that a MenuAcceleratorLabel doesn't crash in 0x0 environment (

    #176646)
    
    This is my attempt to handle
    #6537 for the
    MenuAcceleratorLabel widget.
    
    Co-authored-by: Tong Mu <[email protected]>
    ahmedsameha1 and dkwingsmt authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    180c5b6 View commit details
    Browse the repository at this point in the history
  2. Manual roll Dart to a4485e5ef821 (3.11.0-25.0.dev) (#177132)

    Includes migration from dart/runtime/bin:dart_io_api to
    common_embedder_dart_io
    jason-simmons authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    a14c7fe View commit details
    Browse the repository at this point in the history
  3. Roll Fuchsia Linux SDK from _dd0Jv50H0oUI2Ad8... to ZHuhfPyyV-LcKDLRh…

    …... (#177137)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC [email protected],[email protected] on the revert to ensure that
    a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    5187246 View commit details
    Browse the repository at this point in the history
  4. Tapping outside of SelectableRegion should dismiss the selection (#…

    …176843)
    
    This PR updates selectable region so it dismisses the selection when a
    tap happens outside of it. This is done through the use of `TapRegion`
    and it's `onTapOutside` callback.
    
    
    https://github.com/user-attachments/assets/d5678c85-9d04-4c9c-af16-9a09a001c228
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ---------
    
    Co-authored-by: Renzo Olivares <[email protected]>
    Renzo-Olivares and Renzo Olivares authored Oct 17, 2025
    Configuration menu
    Copy the full SHA
    2f110cc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cbec6e9 View commit details
    Browse the repository at this point in the history
Loading