chore: change function visibility and variable name

Author: fullstackondemand

src/abstract/authorization.php

@@ -14,10 +14,10 @@ abstract class Authorization extends Controller {
     /** Login Function */
     public function login($req, $res) {
 
-        /** Username Variable */
+        /** Username */
         $username = false;
 
-        /** Password Variable */
+        /** Password */
         $password = false;
 
         // Overide Username and Password Value

src/abstract/controller.php

@@ -8,16 +8,16 @@
 /** Abstract Controller Functions */
 abstract class Controller {
 
-    /** Entity or Table All Data */
+    /** Entity All Data */
     private $data;
 
-    /** Model Class */
+    /** Model Class Object */
     private $model;
 
-    /** Abstract Function for Set Model Class */
+    /** Abstract Function for Set Model Class Object */
     abstract protected function setModel();
 
-    /** Abstract Function for Set Table Data */
+    /** Abstract Function for Set Entity All Data */
     abstract protected function setData();
 
     public function __construct() {

src/abstract/model.php

@@ -7,18 +7,18 @@
 /** Abstract Model Functions */
 abstract class Model {
 
-    /** Create Repository from Table */
+    /** Create Repository from Entity */
     private $repository;
 
-    /** Entity or Table */
-    private $table;
+    /** Entity Class String */
+    private $entity;
 
-    /** Abstract Function for Set Table Class */
-    abstract protected function setTable();
+    /** Abstract Function for Set Entity Class String */
+    abstract protected function setEntity();
 
     public function __construct(private EntityManager $entityManager) {
-        $this->table = $this->setTable();
-        $this->repository = $entityManager->getRepository($this->table);
+        $this->entity = $this->setEntity();
+        $this->repository = $entityManager->getRepository($this->entity);
     }
 
     /** Find All Data */
@@ -60,7 +60,7 @@ public function update(array $args, string $id) {
 
     /** Insert Data */
     public function insert(array $args) {
-        $data = new $this->table;
+        $data = new $this->entity;
 
         foreach ($args as $key => $value)
             $data->__set($key, $value);

src/api/category/model.php

@@ -7,7 +7,7 @@
 
 class Model extends AbstractModel {
 
-    protected function setTable() {
+    protected function setEntity() {
         return Category::class;
     }
 }

src/api/category/router.php

@@ -6,7 +6,7 @@
 use RestJS\Api\Category\Controller;
 
 class Router {
-    function __invoke(RouteCollectorProxy $router) {
+    public function __invoke(RouteCollectorProxy $router) {
         $router->get('/', [Controller::class, "findAll"]);
         $router->get('/{id:[0-9]+}/', [Controller::class, "findByColumn"]);
         $router->get('/{slug:[a-z0-9-]+}/', [Controller::class, "findByColumn"]);

src/api/user/model.php

@@ -7,7 +7,7 @@
 
 class Model extends AbstractModel {
 
-    protected function setTable() {
+    protected function setEntity() {
         return User::class;
     }
 }

src/api/user/router.php

@@ -7,7 +7,7 @@
 use RestJS\Middleware\Upload;
 
 class Router {
-    function __invoke(RouteCollectorProxy $router) {
+    public function __invoke(RouteCollectorProxy $router) {
         $router->get('/', [Controller::class, "findAll"]);
         $router->get('/{id:[0-9]+}/', [Controller::class, "findByColumn"]);
         $router->get('/{username:[a-z0-9-]+}/', [Controller::class, "findByColumn"]);

src/middleware/authorization.php

@@ -14,9 +14,9 @@
 /** Authorization Middleware */
 class Authorization implements MiddlewareInterface {
 
-    function __construct(private User $user) {}
+    public function __construct(private User $user) {}
 
-    function process(Request $req, RequestHandler $handler): ResponseInterface {
+    public function process(Request $req, RequestHandler $handler): ResponseInterface {
 
         /** User Access Token */
         $token = $_COOKIE['SSID'] ?? str_replace('Bearer ', '', $req->getHeader('Authorization'))[0] ?? $req->getQueryParams()['accessToken'] ?? null;

src/middleware/upload.php

@@ -11,7 +11,7 @@
 /** File Upload Middleware */
 class Upload implements MiddlewareInterface {
 
-    function process(Request $req, RequestHandler $handler): ResponseInterface {
+    public function process(Request $req, RequestHandler $handler): ResponseInterface {
 
         /** User Upload File */
         $uploadedFile = $req->getUploadedFiles();
@@ -28,9 +28,8 @@ function process(Request $req, RequestHandler $handler): ResponseInterface {
         return $handler->handle($req);
     }
 
-
     /** File Upload to Server Function */
-    function moveUploadedFile(string $directory, string $type, UploadedFileInterface $uploadedFile) {
+    private function moveUploadedFile(string $directory, string $type, UploadedFileInterface $uploadedFile) {
 
         /** File Extension */
         $ext = pathinfo($uploadedFile->getClientFilename(), PATHINFO_EXTENSION);
@@ -42,8 +41,8 @@ function moveUploadedFile(string $directory, string $type, UploadedFileInterface
         !is_dir($directory) && mkdir($directory);
 
         // File Upload to Server
-        $uploadedFile->moveTo($directory . $filename);
+        $uploadedFile->moveTo("{$directory}{$filename}");
 
-        return $directory . $filename;
+        return "{$directory}{$filename}";
     }
 }