fix for empty array

Author: mrfyda

bin/phar/codacycoverage.phar

@@ -2,8 +2,8 @@
 
 namespace Codacy\Coverage\Parser;
 
-use Codacy\Coverage\Report\FileReport;
 use Codacy\Coverage\Report\CoverageReport;
+use Codacy\Coverage\Report\FileReport;
 
 /**
  * Parses Clover XML file and produces a CoverageReport object.
@@ -104,14 +104,14 @@ private function makeFileReportsFromPackages(\SimpleXMLElement $node, $fileRepor
      */
     private function getLineCoverage(\SimpleXMLElement $node)
     {
-        $lineCoverage = array();
+        $lineCoverage = (object)array();
         foreach ($node as $line) {
             $count = intval($line['count']);
             // iterate all lines in that file
             if ($line['type'] == 'stmt' && $count > 0) {
                 $lineNr = (string)$line['num'];
                 $hit = $count;
-                $lineCoverage[$lineNr] = $hit;
+                $lineCoverage->$lineNr = $hit;
             }
         }
         return $lineCoverage;

src/Codacy/Coverage/Parser/CloverParser.php

@@ -2,8 +2,8 @@
 
 namespace Codacy\Coverage\Parser;
 
-use Codacy\Coverage\Report\FileReport;
 use Codacy\Coverage\Report\CoverageReport;
+use Codacy\Coverage\Report\FileReport;
 
 /**
  * Parses XML file, result of phpunit --coverage-xml, and produces
@@ -78,13 +78,13 @@ public function makeReport()
      */
     private function getLineCoverage(\SimpleXMLElement $node)
     {
-        $lineCoverage = array();
+        $lineCoverage = (object)array();
         if ($node->file->coverage) {
             foreach ($node->file->coverage->line as $line) {
                 $count = $line->covered->count();
                 if ($count > 0) {
                     $nr = (string)$line["nr"];
-                    $lineCoverage[$nr] = $count;
+                    $lineCoverage->$nr = $count;
                 }
             }
         }

src/Codacy/Coverage/Parser/PhpUnitXmlParser.php

@@ -52,7 +52,7 @@ private function _canParseClover($path, $rootDir)
         $fileReports = $report->getFileReports();
         $fileReport = $fileReports[1];
 
-        $expLineCoverage = array(11 => 1, 12 => 1, 13 => 1, 16 => 1);
+        $expLineCoverage = (object)array(11 => 1, 12 => 1, 13 => 1, 16 => 1);
         $this->assertEquals($fileReport->getLineCoverage(), $expLineCoverage);
 
         $this->assertEquals("src/Codacy/Coverage/Parser/Parser.php", $parserFileName);

tests/Codacy/Coverage/Parser/CloverParserTest.php

@@ -15,7 +15,7 @@ public function testParsersProduceSameResult()
         $cloverParser = new CloverParser('tests/res/phpunit-clover/clover.xml', '/home/jacke/Desktop/codacy-php');
         $xunitParser = new PhpUnitXmlParser('tests/res/phpunit-clover/index.xml', '/home/jacke/Desktop/codacy-php');
         $xunitParser->setDirOfFileXmls('tests/res/phpunit-clover');
-        $expectedJson = $file = file_get_contents('tests/res/expected.json', true);
+        $expectedJson = file_get_contents('tests/res/expected.json', true);
 
         $jsonProducer = new JsonProducer();
 

tests/Codacy/Coverage/Parser/ParserTest.php

@@ -37,7 +37,7 @@ public function testCanParsePhpUnitXmlReport()
         $this->assertEquals(95, $cloverParserFileReport->getTotal());
 
         $lineCoverage = $configFileReport->getLineCoverage();
-        $expLineCoverage = array(24 => 4, 25 => 4, 26 => 4, 27 => 4, 28 => 4, 29 => 4);
+        $expLineCoverage = (object)array(24 => 4, 25 => 4, 26 => 4, 27 => 4, 28 => 4, 29 => 4);
         $this->assertEquals($lineCoverage, $expLineCoverage);
 
         $configFileName = $configFileReport->getFileName();