Skip to content

Commit 86af0d3

Browse files
Some attempts at fixing cycles compilation
I am not quite sure how it should work. It seems that cycles always require SSE2 support, and the compilation fails on some target ( I just tried on a i586 virtual machine) if we don't set the -msse2 flag. Also there is a crash when I use tree-slp-vectorize! Long term it would be nice to replace cycles with a smaller library that is easier to compile.
1 parent 7d8855f commit 86af0d3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

SConstruct

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,9 @@ if cycles:
139139
])
140140
# Try to improve compilation speed on linux.
141141
if not clang: env.Append(CPPFLAGS='-fno-var-tracking-assignments')
142-
# This seems to fix a crash on windows.
143-
if target_os == 'msys':
144-
env.Append(CXXFLAGS='-msse2 -O3 -fno-tree-slp-vectorize')
142+
# Seems to fix a crash on windows and i386 targets!
143+
env.Append(CXXFLAGS='-msse2 -fno-tree-slp-vectorize')
144+
if target_os == 'msys': env.Append(CXXFLAGS='-O3')
145145

146146
env.Append(CPPFLAGS=['-Wno-sign-compare', '-Wno-strict-aliasing',
147147
'-Wno-uninitialized'])

0 commit comments

Comments
 (0)