Skip to content

Commit 80f9bed

Browse files
author
Stephane Landelle
committed
Percent encoding user info fix, port AsyncHttpClient#521 on master
1 parent b6ad329 commit 80f9bed

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

api/src/main/java/org/asynchttpclient/RequestBuilderBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ private URI toURI(boolean encode) {
170170
AsyncHttpProviderUtils.validateSupportedScheme(originalUri);
171171

172172
StringBuilder builder = new StringBuilder();
173-
builder.append(originalUri.getScheme()).append("://").append(originalUri.getAuthority());
173+
builder.append(originalUri.getScheme()).append("://").append(originalUri.getRawAuthority());
174174
if (isNonEmpty(originalUri.getRawPath())) {
175175
builder.append(originalUri.getRawPath());
176176
} else {

api/src/test/java/org/asynchttpclient/async/RequestBuilderTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,4 +105,11 @@ public void testUserProvidedRequestMethod() {
105105
assertEquals(req.getMethod(), "ABC");
106106
assertEquals(req.getUrl(), "http://foo.com");
107107
}
108+
109+
@Test(groups = {"standalone", "default_provider"})
110+
public void testPercentageEncodedUserInfo() {
111+
final Request req = new RequestBuilder("GET").setUrl("http://hello:wor%[email protected]").build();
112+
assertEquals(req.getMethod(), "GET");
113+
assertEquals(req.getUrl(), "http://hello:wor%[email protected]");
114+
}
108115
}

0 commit comments

Comments
 (0)