Skip to content

Commit f3ab5d3

Browse files
committed
incorporate review feedback from @EliahKagan
1 parent 1731c1e commit f3ab5d3

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

git/util.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,8 @@ def is_cygwin_git(git_executable: PathLike) -> bool: ...
490490

491491

492492
def is_cygwin_git(git_executable: Union[None, PathLike]) -> bool:
493-
_logger.debug(f"sys.platform = {sys.platform}, git_executable = {git_executable}")
493+
# TODO: when py3.7 support is dropped, use the new interpolation f"{variable=}"
494+
_logger.debug(f"sys.platform={sys.platform!r}, git_executable={git_executable!r}")
494495
if sys.platform != "cygwin":
495496
return False
496497
elif git_executable is None:

test/test_util.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ class TestIsCygwinGit:
354354
"""Tests for :func:`is_cygwin_git`"""
355355

356356
def test_on_path_executable(self):
357+
# Currently we assume tests run on Cygwin use Cygwin git. See #533 and #1455 for background.
357358
if sys.platform == "cygwin":
358359
assert is_cygwin_git("git")
359360
else:

0 commit comments

Comments
 (0)