Fix some linting errors

Author: czosel

.eslintrc.js

@@ -8,7 +8,8 @@ module.exports = {
   extends: ["eslint:recommended", "prettier"],
   env: {
     browser: true,
-    node: true
+    node: true,
+    mocha: true
   },
   rules: {
     "prettier/prettier": "error"

.travis.yml

@@ -13,5 +13,5 @@ notifications:
     on_success: change
     on_failure: always
     on_start: never
-script: npm run cover
+script: npm lint && npm run cover
 after_success: cat /home/travis/build/glayzzle/php-parser/coverage/lcov.info | /home/travis/build/glayzzle/php-parser/node_modules/coveralls/bin/coveralls.js

package.json

@@ -5,7 +5,7 @@
   "main": "src/index.js",
   "scripts": {
     "lint": "eslint src/**/*.js test/**/*.js",
-    "test": "node node_modules/mocha/bin/mocha test --stack-size=5000",
+    "test": "npm run lint && node node_modules/mocha/bin/mocha test --stack-size=5000",
     "cover": "node --stack-size=5000 node_modules/istanbul/lib/cli.js cover node_modules/mocha/bin/_mocha"
   },
   "repository": {

src/ast/namespace.js

@@ -5,7 +5,6 @@
  */
 
 var Block = require("./block");
-var Identifier = require("./identifier");
 var KIND = "namespace";
 
 /**

src/lexer/numbers.js

@@ -7,14 +7,11 @@
 "use strict";
 
 /* istanbul ignore else  */
+let MAX_LENGTH_OF_LONG = 10;
+let long_min_digits = "2147483648";
 if (process.arch == "x64") {
-  var SIZEOF_LONG = 8;
-  var MAX_LENGTH_OF_LONG = 19;
-  var long_min_digits = "9223372036854775808";
-} else {
-  var SIZEOF_LONG = 4;
-  var MAX_LENGTH_OF_LONG = 10;
-  var long_min_digits = "2147483648";
+  MAX_LENGTH_OF_LONG = 19;
+  long_min_digits = "9223372036854775808";
 }
 
 module.exports = {

src/lexer/strings.js

@@ -240,7 +240,7 @@ module.exports = {
 
   consume_VARIABLE: function() {
     this.consume_LABEL();
-    ch = this.input();
+    var ch = this.input();
     if (ch == "[") {
       this.unput(1);
       this.begin("ST_VAR_OFFSET");

src/parser/class.js

@@ -159,13 +159,13 @@ module.exports = {
     }
     return this.read_list(
       /**
-         * Reads a constant declaration
-         *
-         * ```ebnf
-         *  constant_declaration ::= (T_STRING | IDENTIFIER) '=' expr
-         * ```
-         * @return {Constant} [:link:](AST.md#constant)
-         */
+       * Reads a constant declaration
+       *
+       * ```ebnf
+       *  constant_declaration ::= (T_STRING | IDENTIFIER) '=' expr
+       * ```
+       * @return {Constant} [:link:](AST.md#constant)
+       */
       function read_constant_declaration() {
         var result = this.node("classconstant"),
           name = null,
@@ -329,7 +329,7 @@ module.exports = {
    * trait ::= T_TRAIT T_STRING (T_EXTENDS (NAMESPACE_NAME ',')* NAMESPACE_NAME)? '{' FUNCTION* '}'
    * ```
    */
-  read_trait: function(flag) {
+  read_trait: function() {
     var result = this.node("trait"),
       propName = null,
       propExtends = null,

src/parser/namespace.js

@@ -119,12 +119,12 @@ module.exports = {
     return result(name.name, alias, type);
   },
   /**
-  * Reads a list of use declarations
-  * ```ebnf
-  * use_declarations ::= use_declaration (',' use_declaration)*
-  * ```
-  * @see https://github.com/php/php-src/blob/master/Zend/zend_language_parser.y#L380
-  * @return {UseItem[]}
+   * Reads a list of use declarations
+   * ```ebnf
+   * use_declarations ::= use_declaration (',' use_declaration)*
+   * ```
+   * @see https://github.com/php/php-src/blob/master/Zend/zend_language_parser.y#L380
+   * @return {UseItem[]}
    */
   read_use_declarations: function(typed) {
     var result = [this.read_use_declaration(typed)];

src/parser/utils.js

@@ -98,7 +98,6 @@ module.exports = {
   read_variable_declarations: function() {
     return this.read_list(function() {
       var node = this.node("assign"),
-        value = null,
         variable = this.node("variable");
       // plain variable name
       if (this.expect(this.tok.T_VARIABLE)) {

test/arrayTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Array without keys", function() {

test/astTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test AST structure", function() {

test/buffer.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test buffers", function() {

test/commentTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test comments", function() {

test/exprTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test expressions", function() {

test/functionTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Function tests", function() {

test/gracefulTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test graceful mode", function() {

test/lexerTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test lexer", function() {

test/locationTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test offsets", function() {

test/namespaceTest.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test namespace statements", function() {

test/numberTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test numbers", function() {

test/perfTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Performance tests", function() {

test/precedence.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 /**

test/scalarTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test scalar statements", function() {

test/statementTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test statements", function() {

test/stringTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("../src/index");
 
 describe("Test strings", function() {

test/variableTests.js

@@ -1,4 +1,3 @@
-var should = require("should");
 var parser = require("./main");
 
 describe("Test variables", function() {