rows: cache parseTime in resultSet instead of mysqlConn

Author: julienschmidt

connection.go

@@ -39,7 +39,6 @@ type mysqlConn struct {
 	flags            clientFlag
 	status           statusFlag
 	sequence         uint8
-	parseTime        bool
 
 	// for context support (Go 1.8+)
 	watching bool
@@ -403,6 +402,9 @@ func (mc *mysqlConn) query(query string, args []driver.Value) (*textRows, error)
 					return nil, err
 				}
 			}
+
+			rows.rs.parseTime = mc.cfg.ParseTime
+
 			// Columns
 			rows.rs.columns, err = mc.readColumns(resLen)
 			return rows, err

driver.go

@@ -63,7 +63,6 @@ func (d MySQLDriver) Open(dsn string) (driver.Conn, error) {
 	if err != nil {
 		return nil, err
 	}
-	mc.parseTime = mc.cfg.ParseTime
 
 	// Connect to Server
 	if dial, ok := dials[mc.cfg.Net]; ok {

packets.go

@@ -761,7 +761,7 @@ func (rows *textRows) readRow(dest []driver.Value) error {
 		pos += n
 		if err == nil {
 			if !isNull {
-				if !mc.parseTime {
+				if !rows.rs.parseTime {
 					continue
 				} else {
 					switch rows.rs.columns[i].fieldType {
@@ -1265,7 +1265,7 @@ func (rows *binaryRows) readRow(dest []driver.Value) error {
 					)
 				}
 				dest[i], err = formatBinaryDateTime(data[pos:pos+int(num)], dstlen, true)
-			case rows.mc.parseTime:
+			case rows.rs.parseTime:
 				dest[i], err = parseBinaryDateTime(num, data[pos:], rows.mc.cfg.Loc)
 			default:
 				var dstlen uint8

rows.go

@@ -18,6 +18,7 @@ type resultSet struct {
 	columns     []mysqlField
 	columnNames []string
 	done        bool
+	parseTime   bool // cached from cfg
 }
 
 type mysqlRows struct {