Skip to content

Commit 1aad2de

Browse files
committed
feat: removed allowImplicitNetworkAccess flag from settings #66861
Signed-off-by: nikzayn <[email protected]>
1 parent 3de08ac commit 1aad2de

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

gopls/internal/doc/api.json

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,6 @@
7979
"Status": "experimental",
8080
"Hierarchy": "build"
8181
},
82-
{
83-
"Name": "allowImplicitNetworkAccess",
84-
"Type": "bool",
85-
"Doc": "allowImplicitNetworkAccess disables GOPROXY=off, allowing implicit module\ndownloads rather than requiring user action. This option will eventually\nbe removed.\n",
86-
"EnumKeys": {
87-
"ValueType": "",
88-
"Keys": null
89-
},
90-
"EnumValues": null,
91-
"Default": "false",
92-
"Status": "experimental",
93-
"Hierarchy": "build"
94-
},
9582
{
9683
"Name": "standaloneTags",
9784
"Type": "[]string",

gopls/internal/settings/settings.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1053,12 +1053,6 @@ func (o *Options) set(name string, value any, seen map[string]struct{}) error {
10531053
case "analysisProgressReporting":
10541054
return setBool(&o.AnalysisProgressReporting, value)
10551055

1056-
case "allowImplicitNetworkAccess":
1057-
if err := setBool(&o.AllowImplicitNetworkAccess, value); err != nil {
1058-
return err
1059-
}
1060-
return softErrorf("gopls setting \"allowImplicitNetworkAccess\" is deprecated.\nPlease comment on https://go.dev/issue/66861 if this impacts your workflow.")
1061-
10621056
case "standaloneTags":
10631057
return setStringSlice(&o.StandaloneTags, value)
10641058

gopls/internal/test/integration/misc/configuration_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ func TestDeprecatedSettings(t *testing.T) {
239239
"experimentalWorkspaceModule": true,
240240
"tempModfile": true,
241241
"allowModfileModifications": true,
242-
"allowImplicitNetworkAccess": true,
243242
},
244243
).Run(t, "", func(t *testing.T, env *Env) {
245244
env.OnceMet(
@@ -249,7 +248,6 @@ func TestDeprecatedSettings(t *testing.T) {
249248
ShownMessage("experimentalWatchedFileDelay"),
250249
ShownMessage("tempModfile"),
251250
ShownMessage("allowModfileModifications"),
252-
ShownMessage("allowImplicitNetworkAccess"),
253251
)
254252
})
255253
}

0 commit comments

Comments
 (0)