enable grpc metrics only env is set to false

surbhigarg92 · surbhigarg92 · commit 94e81616ccd1 · 2025-04-16T22:42:38.000+05:30
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
@@ -919,8 +919,8 @@ public boolean isEnableBuiltInMetrics() {
 
     @Override
     public boolean isEnableGRPCBuiltInMetrics() {
-      return !Boolean.parseBoolean(
-          System.getenv(SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS));
+      return "false"
+          .equalsIgnoreCase(System.getenv(SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS));
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -919,8 +919,8 @@ public boolean isEnableBuiltInMetrics() {`
`919`	`919`
`920`	`920`	`@Override`
`921`	`921`	`public boolean isEnableGRPCBuiltInMetrics() {`
`922`		`- return !Boolean.parseBoolean(`
`923`		`- System.getenv(SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS));`
	`922`	`+ return "false"`
	`923`	`+ .equalsIgnoreCase(System.getenv(SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS));`
`924`	`924`	`}`
`925`	`925`
`926`	`926`	`@Override`