Skip to content
This repository was archived by the owner on Aug 19, 2020. It is now read-only.

Conversation

bamboo
Copy link
Member

@bamboo bamboo commented Nov 14, 2018

To minimize confusion when migrating away from the eager API.

To minimize confusion when migrating away from the eager API.
@bamboo bamboo added this to the 1.0.3 milestone Nov 14, 2018
@bamboo bamboo self-assigned this Nov 14, 2018
@bamboo bamboo merged commit d0295e2 into develop Nov 14, 2018
@JLLeitschuh
Copy link
Contributor

The config avoidance API is what the new API Gradle wants users to be using moving forward.
These changes seem to be at odds with that goal. I'm confused.

@eskatos
Copy link
Member

eskatos commented Nov 14, 2018

@JLLeitschuh use registering or existing for configuration avoidance. creating and getting should be eager, they should simply delegate to create() and getByName(), just like registering and existing respectively delegate to register() and named(). This change and #1247 makes the eager delegated properties behavior more coherent, less surprising.

@JLLeitschuh
Copy link
Contributor

Okay, this makes sense. I'm glad that there's an alternative that still provides support for config avoidance.

@eskatos eskatos changed the title Let creating property delegate use create instead of register Let creating property delegate use create() instead of register() Nov 14, 2018
@bamboo bamboo deleted the bamboo/let-creating-use-create branch December 11, 2018 00:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants