Merge pull request cpp-netlib#465 from povilasb/0.11-devel-fix-warnings

Fixed compilation warnings.

Author: deanberris

boost/network/protocol/http/client/connection/async_normal.hpp

@@ -199,6 +199,9 @@ struct http_async_connection
                            body_generator_function_type generator,
                            boost::system::error_code const& ec,
                            std::size_t bytes_transferred) {
+    // TODO(dberris): review parameter necessity.
+    (void)bytes_transferred;
+
     if (!is_timedout_ && !ec) {
       if (generator) {
         // Here we write some more data that the generator provides,

boost/network/protocol/http/client/connection/async_protocol_handler.hpp

@@ -46,23 +46,32 @@ struct http_async_protocol_handler {
 
   template <class ResponseType>
   void init_response(ResponseType& response_, bool get_body) {
+    // TODO(dberris): review parameter necessity.
+    (void)get_body;
+
     boost::shared_future<string_type> source_future(
         source_promise.get_future());
     source(response_, source_future);
+
     boost::shared_future<string_type> destination_future(
         destination_promise.get_future());
     destination(response_, destination_future);
+
     boost::shared_future<typename headers_container<Tag>::type> headers_future(
         headers_promise.get_future());
     headers(response_, headers_future);
+
     boost::shared_future<string_type> body_future(body_promise.get_future());
     body(response_, body_future);
+
     boost::shared_future<string_type> version_future(
         version_promise.get_future());
     version(response_, version_future);
+
     boost::shared_future<boost::uint16_t> status_future(
         status_promise.get_future());
     status(response_, status_future);
+
     boost::shared_future<string_type> status_message_future(
         status_message_promise.get_future());
     status_message(response_, status_message_future);

boost/network/protocol/http/client/connection/normal_delegate.ipp

@@ -21,6 +21,10 @@ boost::network::http::impl::normal_delegate::normal_delegate(
 void boost::network::http::impl::normal_delegate::connect(
     asio::ip::tcp::endpoint &endpoint, std::string host,
     function<void(system::error_code const &)> handler) {
+
+  // TODO(dberris): review parameter necessity.
+  (void)host;
+
   socket_.reset(new asio::ip::tcp::socket(service_));
   socket_->async_connect(endpoint, handler);
 }

boost/network/protocol/http/client/connection/sync_base.hpp

@@ -102,13 +102,19 @@ struct sync_connection_base_impl {
   template <class Socket>
   void send_request_impl(Socket& socket_, string_type const& method,
                          boost::asio::streambuf& request_buffer) {
+    // TODO(dberris): review parameter necessity.
+    (void)method;
+
     write(socket_, request_buffer);
   }
 
   template <class Socket>
   void read_body_normal(Socket& socket_, basic_response<Tag>& response_,
                         boost::asio::streambuf& response_buffer,
                         typename ostringstream<Tag>::type& body_stream) {
+    // TODO(dberris): review parameter necessity.
+    (void)response_;
+
     boost::system::error_code error;
     if (response_buffer.size() > 0) body_stream << &response_buffer;
 

boost/network/protocol/http/policies/pooled_connection.hpp

@@ -65,7 +65,12 @@ struct pooled_connection_policy : resolver_policy<Tag>::type {
           certificate_filename_(certificate_filename),
           verify_path_(verify_path),
           certificate_file_(certificate_file),
-          private_key_file_(private_key_file) {}
+          private_key_file_(private_key_file) {
+
+      // TODO(dberris): review parameter necessity.
+      (void)host;
+      (void)port;
+    }
 
     basic_response<Tag> send_request(string_type const& method,
                                      basic_request<Tag> request_, bool get_body,
@@ -79,6 +84,9 @@ struct pooled_connection_policy : resolver_policy<Tag>::type {
         string_type const& method, basic_request<Tag> request_, bool get_body,
         body_callback_function_type callback,
         body_generator_function_type generator) {
+      // TODO(dberris): review parameter necessity.
+      (void)callback;
+
       boost::uint8_t count = 0;
       bool retry = false;
       do {

boost/network/protocol/http/policies/simple_connection.hpp

@@ -50,6 +50,11 @@ struct simple_connection_policy : resolver_policy<Tag>::type {
         optional<string_type> const& certificate_file = optional<string_type>(),
         optional<string_type> const& private_key_file = optional<string_type>())
         : pimpl(), follow_redirect_(follow_redirect) {
+
+      // TODO(dberris): review parameter necessity.
+      (void)hostname;
+      (void)port;
+
       pimpl.reset(impl::sync_connection_base<
           Tag, version_major,
           version_minor>::new_connection(resolver, resolve, https,
@@ -62,6 +67,9 @@ struct simple_connection_policy : resolver_policy<Tag>::type {
                                      basic_request<Tag> request_, bool get_body,
                                      body_callback_function_type callback,
                                      body_generator_function_type generator) {
+      // TODO(dberris): review parameter necessity.
+      (void)callback;
+
       basic_response<Tag> response_;
       do {
         pimpl->init_socket(request_.host(),