From 32b0d7ac89a8fc74260c9b47b48d7ac658e343bc Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 14:34:06 -0600 Subject: [PATCH 1/6] adding markdown linter --- .github/workflows/markdown-linter.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 .github/workflows/markdown-linter.yml diff --git a/.github/workflows/markdown-linter.yml b/.github/workflows/markdown-linter.yml new file mode 100644 index 00000000..f0191989 --- /dev/null +++ b/.github/workflows/markdown-linter.yml @@ -0,0 +1,13 @@ +# This is a basic workflow to help you get started with Actions + +name: Check Markdown Links + +on: push + +jobs: + markdown-link-check: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@master + - uses: gaurav-nelson/github-action-markdown-link-check@v1 + folder-path: _posts From 2ea1d7df7b1b829e1c087625ba1d6fbf7b69967d Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 14:35:34 -0600 Subject: [PATCH 2/6] fixing --- .github/workflows/markdown-linter.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/markdown-linter.yml b/.github/workflows/markdown-linter.yml index f0191989..21abdedb 100644 --- a/.github/workflows/markdown-linter.yml +++ b/.github/workflows/markdown-linter.yml @@ -10,4 +10,5 @@ jobs: steps: - uses: actions/checkout@master - uses: gaurav-nelson/github-action-markdown-link-check@v1 - folder-path: _posts + with: + folder-path: _posts From bd9b245d9498ad3da13af11e99fe26b4b722a25e Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 14:44:49 -0600 Subject: [PATCH 3/6] adding md check config --- .github/workflows/markdown-linter.yml | 1 + mlc_config.json | 7 +++++++ 2 files changed, 8 insertions(+) create mode 100644 mlc_config.json diff --git a/.github/workflows/markdown-linter.yml b/.github/workflows/markdown-linter.yml index 21abdedb..a0207a62 100644 --- a/.github/workflows/markdown-linter.yml +++ b/.github/workflows/markdown-linter.yml @@ -12,3 +12,4 @@ jobs: - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: folder-path: _posts + config_file: mlc_config.json diff --git a/mlc_config.json b/mlc_config.json new file mode 100644 index 00000000..114e82e4 --- /dev/null +++ b/mlc_config.json @@ -0,0 +1,7 @@ +{ + "baseurl": [ + { + "pattern": "https://josh-ops.com/" + } + ] +} \ No newline at end of file From 5ebce9d8cef3d75f3896341a61186d481840bf61 Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 14:46:45 -0600 Subject: [PATCH 4/6] fixing parameter --- .github/workflows/markdown-linter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/markdown-linter.yml b/.github/workflows/markdown-linter.yml index a0207a62..dcfd5d9b 100644 --- a/.github/workflows/markdown-linter.yml +++ b/.github/workflows/markdown-linter.yml @@ -12,4 +12,4 @@ jobs: - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: folder-path: _posts - config_file: mlc_config.json + config-file: mlc_config.json From a9ff9c3debccf884e1dd2b7932523c6d51af9a5f Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 14:51:28 -0600 Subject: [PATCH 5/6] updating replacement pattern --- mlc_config.json | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/mlc_config.json b/mlc_config.json index 114e82e4..529dcce0 100644 --- a/mlc_config.json +++ b/mlc_config.json @@ -1,7 +1,8 @@ { - "baseurl": [ - { - "pattern": "https://josh-ops.com/" - } - ] + "replacementPatterns": [ + { + "pattern": "^/", + "replacement": "https://josh-ops.com/" + } + ] } \ No newline at end of file From 6db23bad9feeb3e3cc7d8680127bc3c31d470a04 Mon Sep 17 00:00:00 2001 From: Josh Johanning Date: Fri, 7 Jan 2022 15:00:50 -0600 Subject: [PATCH 6/6] fixing broken links --- _posts/2020-12-16-github-codeql-pr.md | 2 +- _posts/2021-01-25-trac-to-github.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/_posts/2020-12-16-github-codeql-pr.md b/_posts/2020-12-16-github-codeql-pr.md index 151ca0d3..f2f2afef 100644 --- a/_posts/2020-12-16-github-codeql-pr.md +++ b/_posts/2020-12-16-github-codeql-pr.md @@ -13,7 +13,7 @@ image: ## Overview -After virtually attending GitHub Universe last week and watching the [GitHub Advanced Security round-up](https://githubuniverse.com/GitHub-Advanced-Security-round-up/) and [Catching vulnerabilities early with GitHub](https://githubuniverse.com/Catching-vulnerabilities-early-with-GitHub/) sessions, it got me thinking: How do I block a pull request from being merged if the scans detect issues? I didn't think the [GitHub Docs](https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository#understanding-the-pull-request-checks) were incredibly straight forward on how this works. +After virtually attending GitHub Universe last week and watching the [GitHub Advanced Security round-up](https://www.youtube.com/watch?v=T_-Tn81b4lc) and [Catching vulnerabilities early with GitHub](https://www.youtube.com/watch?v=l2epzyytPGE) sessions, it got me thinking: How do I block a pull request from being merged if the scans detect issues? I didn't think the [GitHub Docs](https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/enabling-code-scanning-for-a-repository#understanding-the-pull-request-checks) were incredibly straight forward on how this works. I knew how to configure a branch protection rule in GitHub that enforces things such as a GitHub Action or Azure DevOps stage completes successfully, but what about code scanning? How configurable is it? diff --git a/_posts/2021-01-25-trac-to-github.md b/_posts/2021-01-25-trac-to-github.md index 44281858..4ed27734 100644 --- a/_posts/2021-01-25-trac-to-github.md +++ b/_posts/2021-01-25-trac-to-github.md @@ -14,7 +14,7 @@ We were working with a client who was migrating off of their old Trac server, an ## Tools -There are plenty of tools out there on GitHub ([svigerske/trac-to-github](https://github.com/svigerske/trac-to-github), [robertoschwald/migrate-trac-issues-to-github](https://github.com/robertoschwald/migrate-trac-issues-to-github), [hershwg/github-migrate-trac-tickets](https://github.com/hershwg/github-migrate-trac-tickets)... some of them require [XML-RPC](https://trac-hacks.org/wiki/XmlRpcPlugin), which I had a heck of a time installing on my Apache Trac webserver, so I wasn't able to test those. +There are plenty of tools out there on GitHub ([svigerske/trac-to-github](https://github.com/svigerske/trac-to-github), [robertoschwald/migrate-trac-issues-to-github](https://web.archive.org/web/20200912010021/https://github.com/robertoschwald/migrate-trac-issues-to-github), [hershwg/github-migrate-trac-tickets](https://github.com/hershwg/github-migrate-trac-tickets)... some of them require [XML-RPC](https://trac-hacks.org/wiki/XmlRpcPlugin), which I had a heck of a time installing on my Apache Trac webserver, so I wasn't able to test those. The two I have tested are: