Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Popup slide reverse transition doesn't return in correct direction #5134

Closed
groovy21 opened this issue Oct 5, 2012 · 3 comments
Closed

Popup slide reverse transition doesn't return in correct direction #5134

groovy21 opened this issue Oct 5, 2012 · 3 comments

Comments

@groovy21
Copy link

groovy21 commented Oct 5, 2012

Description
When a reverse slide transition is invoked on a popup, it moves from left from right. But when it is disposed, the return transition is from left to right.

Test page is http://jsbin.com/uzaret/25

Steps to reproduce:
Apply "reverse slide" transition to a popup. Or use the attached test page.

Expected outcome:
Popup moves from left to right when invoked and returns from right to left when disposed

Actual outcome:
Popup moves from left to right when invoked and returns from left to right when disposed

Platforms/browsers - are mentioned in the test page

jquery mobile version 1.2.0

@billkeller
Copy link

Is there a test page which shows this fix resolved? I've applied the changes found in your pull request, but the behavior does not change.

@groovy21
Copy link
Author

groovy21 commented Feb 8, 2013

Hi,

I dont know if my request qualified as a pull request because I never
intended to do so and never made a fix. I merely reported the bug and
someone said that it would get fixed. I can look up who that was if you
want?

Thanks,
Sid

On Thu, Feb 7, 2013 at 10:07 AM, billkeller [email protected]:

Is there a test page which shows this fix resolved? I've applied the
changes found in your pull request, but the behavior does not change.


Reply to this email directly or view it on GitHubhttps://github.com//issues/5134#issuecomment-13239693.

@arschmitz
Copy link
Contributor

This has since been fixed we added direction tracking to all page changes closing as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants