Skip to content

Commit 669e0fe

Browse files
drummm1guelpf
authored andcommitted
Only encode the slashes, not the dots
1 parent c9a51ed commit 669e0fe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/Gitlab/Tests/Api/TagsTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public function shouldCreateRelease($releaseName, $description, $expectedResult)
9494
$api = $this->getApiMock();
9595
$api->expects($this->once())
9696
->method('post')
97-
->with('projects/1/repository/tags/' . urlencode($releaseName) . '/release', $params)
97+
->with('projects/1/repository/tags/' . str_replace('/', '%2F', $releaseName) . '/release', $params)
9898
->will($this->returnValue($expectedResult));
9999

100100
$this->assertEquals($expectedResult, $api->createRelease(1, $releaseName, $params));
@@ -116,7 +116,7 @@ public function shouldUpdateRelease($releaseName, $description, $expectedResult)
116116
$api = $this->getApiMock();
117117
$api->expects($this->once())
118118
->method('put')
119-
->with('projects/1/repository/tags/' . urlencode($releaseName) . '/release', $params)
119+
->with('projects/1/repository/tags/' . str_replace('/', '%2F', $releaseName) . '/release', $params)
120120
->will($this->returnValue($expectedResult));
121121

122122
$this->assertEquals($expectedResult, $api->updateRelease(1, $releaseName, $params));

0 commit comments

Comments
 (0)