- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Comparing changes
Open a pull request
base repository: kubernetes-sigs/controller-runtime
base: v0.17.2
head repository: kubernetes-sigs/controller-runtime
compare: v0.17.3
- 8 commits
- 12 files changed
- 5 contributors
Commits on Mar 17, 2024
- 
  Signed-off-by: Stefan Büringer [email protected] Configuration menu - View commit details
- 
    
    
    Copy full SHA for 55d540b 
- Browse repository at this point
 Copy the full SHA 55d540bView commit details 
- 
  Merge pull request #2711 from sbueringer/pr-bump-1.29 [release-0.17] 🌱 Update to Kubernetes v1.29.2 Configuration menu - View commit details
- 
    
    
    Copy full SHA for bd9ea79 
- Browse repository at this point
 Copy the full SHA bd9ea79View commit details 
Commits on Apr 2, 2024
- 
  bug: Cache: Keep selectors when byObject.Namespaces is defaulted Prior to this patch, configuring for example a labelSelector in `ByObject` and then inheriting namespaces from `DefaultNamespaces` meant that the `labelSelector` would be ignored. This is because if namespaces are configured, we set p a multinamespace cache. If we do that, we expect each namespace entry to have the appropriate selectors configured. Unfortunately we defaulted the configs for`byObject.Namespaces` before defaulting `byObject.Namespace` itself, causing the above-described issue. This change also adds a couple more tests for the cache defaulting. Configuration menu - View commit details
- 
    
    
    Copy full SHA for 64dd305 
- Browse repository at this point
 Copy the full SHA 64dd305View commit details 
- 
  Merge pull request #2749 from k8s-infra-cherrypick-robot/cherry-pick-… …2747-to-release-0.17 [release-0.17] 🐛 Cache: Keep selectors when byObject.Namespaces is defaulted Configuration menu - View commit details
- 
    
    
    Copy full SHA for 8968da8 
- Browse repository at this point
 Copy the full SHA 8968da8View commit details 
- 
  🐛 prevent leader election when shutting down a non-elected manager When leader election is enabled, a non-leader manager would never start the LeaderElection runnable group. Thus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election. This change ensures `Start` is ineffective during shutdown. The test ensures the LeaderElection runnableGroup is not started during shutdown. Signed-off-by: Alexandre Mahdhaoui <[email protected]> Configuration menu - View commit details
- 
    
    
    Copy full SHA for d39bab8 
- Browse repository at this point
 Copy the full SHA d39bab8View commit details 
- 
  Merge pull request #2752 from k8s-infra-cherrypick-robot/cherry-pick-… …2724-to-release-0.17 [release-0.17] 🐛 prevent leader election when shutting down a non-elected manager Configuration menu - View commit details
- 
    
    
    Copy full SHA for 854a6b1 
- Browse repository at this point
 Copy the full SHA 854a6b1View commit details 
Commits on Apr 5, 2024
- 
  bug: Runnable group should check if stopped before enqueueing Signed-off-by: Vince Prignano <[email protected]> Configuration menu - View commit details
- 
    
    
    Copy full SHA for f5833f3 
- Browse repository at this point
 Copy the full SHA f5833f3View commit details 
- 
  Merge pull request #2761 from k8s-infra-cherrypick-robot/cherry-pick-… …2757-to-release-0.17 [release-0.17] 🐛 Runnable group should check if stopped before enqueueing Configuration menu - View commit details
- 
    
    
    Copy full SHA for c25fe2f 
- Browse repository at this point
 Copy the full SHA c25fe2fView commit details 
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
            You can try running this command locally to see the comparison on your machine: 
            git diff v0.17.2...v0.17.3