Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.17.2
Choose a base ref
...
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.17.3
Choose a head ref
  • 8 commits
  • 12 files changed
  • 5 contributors

Commits on Mar 17, 2024

  1. Update to Kubernetes v1.29.2

    Signed-off-by: Stefan Büringer [email protected]
    sbueringer committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    55d540b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2711 from sbueringer/pr-bump-1.29

    [release-0.17] 🌱 Update to Kubernetes v1.29.2
    k8s-ci-robot authored Mar 17, 2024
    Configuration menu
    Copy the full SHA
    bd9ea79 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. bug: Cache: Keep selectors when byObject.Namespaces is defaulted

    Prior to this patch, configuring for example a labelSelector in
    `ByObject` and then inheriting namespaces from `DefaultNamespaces` meant
    that the `labelSelector` would be ignored. This is because if namespaces
    are configured, we set p a multinamespace cache. If we do that, we
    expect each namespace entry to have the appropriate selectors
    configured.
    
    Unfortunately we defaulted the configs for`byObject.Namespaces` before
    defaulting `byObject.Namespace` itself, causing the above-described
    issue.
    
    This change also adds a couple more tests for the cache defaulting.
    alvaroaleman authored and k8s-infra-cherrypick-robot committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    64dd305 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2749 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2747-to-release-0.17
    
    [release-0.17] 🐛 Cache: Keep selectors when byObject.Namespaces is defaulted
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8968da8 View commit details
    Browse the repository at this point in the history
  3. 🐛 prevent leader election when shutting down a non-elected manager

    When leader election is enabled, a non-leader manager would never start the LeaderElection runnable group.
    Thus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election.
    This change ensures `Start` is ineffective during shutdown.
    
    The test ensures the LeaderElection runnableGroup is not started during shutdown.
    
    Signed-off-by: Alexandre Mahdhaoui <[email protected]>
    alexandremahdhaoui authored and k8s-infra-cherrypick-robot committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d39bab8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2752 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2724-to-release-0.17
    
    [release-0.17] 🐛 prevent leader election when shutting down a non-elected manager
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    854a6b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. bug: Runnable group should check if stopped before enqueueing

    Signed-off-by: Vince Prignano <[email protected]>
    vincepri authored and k8s-infra-cherrypick-robot committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f5833f3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2761 from k8s-infra-cherrypick-robot/cherry-pick-…

    …2757-to-release-0.17
    
    [release-0.17] 🐛 Runnable group should check if stopped before enqueueing
    k8s-ci-robot authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c25fe2f View commit details
    Browse the repository at this point in the history
Loading