Skip to content

Conversation

@aepod
Copy link
Contributor

@aepod aepod commented Jan 16, 2020

Description

This change adds a command to the entrypoint.sh which will copy in the php.ini from the root directory. This happens before the php-fpm service or cli command is run.

This creates zzz-custom-php.ini which is named so it comes last, after all the default docker and magento extension configurations.

Windows/Mac users who are using file synchronization will need to ensure that the file sync is complete or the php.ini will not be copied into the configuration directory.

Fixed Issues (if relevant)

  1. Add possibility to read php.ini  #126: Add possibility to read php.ini

Manual testing scenarios

  1. See Added Specify Docker Build Sources section to Extending Docker Page devdocs#6408 for details on how to import from custom docker image
  2. Once you are building from vendor/magento/magento-cloud-docker/images/php/phpversion/ you should be able to test this.

Please let me know if you have any questions.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@aepod
Copy link
Contributor Author

aepod commented Jan 17, 2020

@bbatsche I sorted out the order on those, missed that when I brought the changes into the template.

@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality shiftedreality merged commit 05ff83f into magento:develop Jan 29, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 5, 2024
MCLOUD-12025 Cloud Tools Releas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants