-
Notifications
You must be signed in to change notification settings - Fork 197
Custom php.ini from root directory #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsche
suggested changes
Jan 17, 2020
|
@bbatsche I sorted out the order on those, missed that when I brought the changes into the template. |
bbatsche
approved these changes
Jan 17, 2020
oshmyheliuk
reviewed
Jan 17, 2020
oshmyheliuk
approved these changes
Jan 17, 2020
|
QA approved |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 5, 2024
MCLOUD-12025 Cloud Tools Releas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
PR/issue origin
Partner: Zilker Technology
partners-contribution
Progress: accept
PR/issue status
Release Line: 1.1
Release: 1.1.0
release-note-completed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a command to the entrypoint.sh which will copy in the php.ini from the root directory. This happens before the php-fpm service or cli command is run.
This creates zzz-custom-php.ini which is named so it comes last, after all the default docker and magento extension configurations.
Windows/Mac users who are using file synchronization will need to ensure that the file sync is complete or the php.ini will not be copied into the configuration directory.
Fixed Issues (if relevant)
Manual testing scenarios
Please let me know if you have any questions.
Contribution checklist