Skip to content

Pinned composer dependency to rector 0.17.12 #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmuench opened this issue Sep 13, 2023 · 1 comment · Fixed by #469
Closed

Pinned composer dependency to rector 0.17.12 #464

cmuench opened this issue Sep 13, 2023 · 1 comment · Fixed by #469
Labels
bug Something isn't working Progress: done

Comments

@cmuench
Copy link

cmuench commented Sep 13, 2023

With the last release v32 the dependency to rector was changed from ^0.15.10 to 0.17.12. To pin the dependency to a fixed version is a bad practice in the PHP world.

It's better to define it at least as ~0.17.12 to allow bug fix releases of rector.
In the meantime a 0.17.3 of rector is released which cannot be updated in a Magento project.

@cmuench cmuench added the bug Something isn't working label Sep 13, 2023
@m2-assistant
Copy link

m2-assistant bot commented Sep 13, 2023

Hi @cmuench. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Progress: done
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant