Merge pull request Leaflet#1856 from rutkovsky/disable_animations_outside_dom

Disable animations outside dom

Author: mourner

spec/suites/dom/PosAnimationSpec.js

@@ -0,0 +1,27 @@
+describe('PosAnimation', function() {
+	var el;
+
+	beforeEach(function() {
+		el = document.createElement('div');
+		this.subject = new L.PosAnimation();
+		this.subject._el = el;
+	});
+
+	describe('#_onStep', function() {
+		it("sets element position and fires step event if it is able to get current position", function() {
+			var point = new L.Point(5, 5, true);
+			sinon.stub(this.subject, '_getPos').returns(point);
+			this.subject.fire = sinon.stub();
+			this.subject._onStep();
+			expect(this.subject.fire.withArgs('step').calledOnce).to.be(true);
+			expect(this.subject._el._leaflet_pos).to.be(point);
+		});
+
+		it('stops transition if a position returned', function() {
+			sinon.stub(this.subject, '_onTransitionEnd');
+			sinon.stub(this.subject, '_getPos').returns(undefined);
+			this.subject._onStep();
+			expect(this.subject._onTransitionEnd.calledOnce).to.be(true);
+		});
+	});
+});

src/dom/PosAnimation.js

@@ -39,9 +39,14 @@ L.PosAnimation = L.Class.extend({
 	},
 
 	_onStep: function () {
+		var stepPos = this._getPos();
+		if (!stepPos) {
+			this._onTransitionEnd();
+			return;
+		}
 		// jshint camelcase: false
 		// make L.DomUtil.getPosition return intermediate position value during animation
-		this._el._leaflet_pos = this._getPos();
+		this._el._leaflet_pos = stepPos;
 
 		this.fire('step');
 	},
@@ -58,8 +63,9 @@ L.PosAnimation = L.Class.extend({
 
 		if (L.Browser.any3d) {
 			matches = style[L.DomUtil.TRANSFORM].match(this._transformRe);
-			left = matches ? parseFloat(matches[1]) : 0;
-			top  = matches ? parseFloat(matches[2]) : 0;
+			if (!matches) { return; }
+			left = parseFloat(matches[1]);
+			top  = parseFloat(matches[2]);
 		} else {
 			left = parseFloat(style.left);
 			top  = parseFloat(style.top);