Skip to content

BugFix: IE11 powerbi.reset() doesn't work #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2017
Merged

BugFix: IE11 powerbi.reset() doesn't work #174

merged 4 commits into from
Mar 20, 2017

Conversation

@ajurzak
Copy link

@ajurzak ajurzak commented Mar 16, 2017

No description provided.

@msftclas
Copy link

msftclas commented Mar 16, 2017

@ajurzak,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas msftclas added the duplicate This issue or pull request already exists label Mar 16, 2017
@ali-hamud
Copy link
Contributor

ali-hamud commented Mar 16, 2017

@ajurzak
Thank you, we will look into it.

@ajurzak ajurzak changed the base branch from dev to master March 17, 2017 15:28
@ajurzak
Copy link
Author

ajurzak commented Mar 17, 2017 •
edited
Loading

I've changed from dev to master.

@msftclas
Copy link

msftclas commented Mar 17, 2017

@ajurzak, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@msftclas msftclas added feature-request New feature or request and removed duplicate This issue or pull request already exists labels Mar 17, 2017
ali-hamud
ali-hamud requested changes Mar 19, 2017
View reviewed changes
Copy link
Contributor

@ali-hamud ali-hamud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, Thank you very much for contributing for our team.
Please remove the js files and js.map files, we will build them internally.
code looks good. please remove:
powerbi.js
powerbi.js.map
powerbi.min.js
from the pull request and I will approve.

@ali-hamud ali-hamud requested review from noanu and somriar March 20, 2017 08:56
@ali-hamud ali-hamud merged commit 5ea6966 into microsoft:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ali-hamud ali-hamud ali-hamud approved these changes

+2 more reviewers

@somriar somriar somriar approved these changes

@noanu noanu noanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature-request New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ajurzak @msftclas @ali-hamud @somriar @noanu