bad case: enum type use number and set default, then it has sql error.

hy0kl · hy0kl · commit 685b5703c08f · 2016-07-25T16:20:57.000+08:00
diff --git a/Convertor.class.php b/Convertor.class.php
@@ -335,10 +335,11 @@ private function convert_field_data($attrs)
                 if (isset($attrs['Default'])) {
                     if ($attrs['Default'] != "") {
                         //TODO: See more cases!
-                        if (is_numeric($attrs['Default']) || in_array($attrs['Default'], $this->defaultWords)) {
-                            $fieldStr .= " DEFAULT ".$attrs['Default'];
+                        if (substr($attrs['Type'], 0, 4) != "enum"
+                            && (is_numeric($attrs['Default']) || in_array($attrs['Default'], $this->defaultWords))) {
+                            $fieldStr .= " DEFAULT " . $attrs['Default'];
                         } else {
-                            $fieldStr .= " DEFAULT '".$attrs['Default']."'";
+                            $fieldStr .= " DEFAULT '" . $attrs['Default'] . "'";
                         }
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -335,10 +335,11 @@ private function convert_field_data($attrs)`
`335`	`335`	`if (isset($attrs['Default'])) {`
`336`	`336`	`if ($attrs['Default'] != "") {`
`337`	`337`	`//TODO: See more cases!`
`338`		`- if (is_numeric($attrs['Default']) \|\| in_array($attrs['Default'], $this->defaultWords)) {`
`339`		`- $fieldStr .= " DEFAULT ".$attrs['Default'];`
	`338`	`+ if (substr($attrs['Type'], 0, 4) != "enum"`
	`339`	`+ && (is_numeric($attrs['Default']) \|\| in_array($attrs['Default'], $this->defaultWords))) {`
	`340`	`+ $fieldStr .= " DEFAULT " . $attrs['Default'];`
`340`	`341`	`} else {`
`341`		`- $fieldStr .= " DEFAULT '".$attrs['Default']."'";`
	`342`	`+ $fieldStr .= " DEFAULT '" . $attrs['Default'] . "'";`
`342`	`343`	`}`
`343`	`344`	`}`
`344`	`345`	`}`