From c95666d39c198e90800c0c3d943aeaf958c6a0a2 Mon Sep 17 00:00:00 2001
From: Juzar Bharmal <53657281+Juzar10@users.noreply.github.com>
Date: Tue, 26 Jan 2021 21:08:54 +0530
Subject: [PATCH] fixed one sided binary tree issue (#51)

---
 Trees/BinarySearchTree.py | 34 ++++++++++++++++++++++++++++------
 1 file changed, 28 insertions(+), 6 deletions(-)

diff --git a/Trees/BinarySearchTree.py b/Trees/BinarySearchTree.py
index 2b6333a..ea0e15a 100644
--- a/Trees/BinarySearchTree.py
+++ b/Trees/BinarySearchTree.py
@@ -44,23 +44,45 @@ def minValueNode(self, node):
 
         return current
 
-    def delete(self, data):
+    def maxValueNode(self, node):
+        current = node
+
+        # loop down to find the leftmost leaf
+        while(current.rightChild is not None):
+            current = current.rightChild
+
+        return current
+
+
+    def delete(self, data,root):
         ''' For deleting the node '''
         if self is None:
             return None
 
         # if current node's data is less than that of root node, then only search in left subtree else right subtree
         if data < self.data:
-            self.leftChild = self.leftChild.delete(data)
+            self.leftChild = self.leftChild.delete(data,root)
         elif data > self.data:
-            self.rightChild = self.rightChild.delete(data)
+            self.rightChild = self.rightChild.delete(data,root)
         else:
             # deleting node with one child
             if self.leftChild is None:
+
+                if self == root:
+                    temp = self.minValueNode(self.rightChild)
+                    self.data = temp.data
+                    self.rightChild = self.rightChild.delete(temp.data,root) 
+
                 temp = self.rightChild
                 self = None
                 return temp
             elif self.rightChild is None:
+
+                if self == root:
+                    temp = self.maxValueNode(self.leftChild)
+                    self.data = temp.data
+                    self.leftChild = self.leftChild.delete(temp.data,root) 
+
                 temp = self.leftChild
                 self = None
                 return temp
@@ -69,7 +91,7 @@ def delete(self, data):
             # first get the inorder successor
             temp = self.minValueNode(self.rightChild)
             self.data = temp.data
-            self.rightChild = self.rightChild.delete(temp.data)
+            self.rightChild = self.rightChild.delete(temp.data,root)
 
         return self
 
@@ -128,7 +150,7 @@ def insert(self, data):
 
     def delete(self, data):
         if self.root is not None:
-            return self.root.delete(data)
+            return self.root.delete(data,self.root)
 
     def find(self, data):
         if self.root:
@@ -189,4 +211,4 @@ def postorder(self):
     print('\n\nAfter deleting 10')
     tree.delete(10)
     tree.inorder()
-    tree.preorder()
+    tree.preorder()
\ No newline at end of file