Fix compiler warnings (-Wignored-qualifiers and -Wunused-parameter)

Sven Over · glynos · commit f78cab30462b · 2012-02-29T22:43:17.000+01:00
Declaring return types as const has no effect. GCC warns you when it
encounters such meaningless qualifiers.
diff --git a/boost/network/protocol/http/impl/message.ipp b/boost/network/protocol/http/impl/message.ipp
@@ -129,7 +129,7 @@ namespace boost { namespace network { namespace http {
     }
 
     template <typename Tag>
-    bool const message_impl<Tag>::base64_decode(const typename message_impl<Tag>::string_type &input, typename message_impl<Tag>::string_type &output)
+    bool message_impl<Tag>::base64_decode(const typename message_impl<Tag>::string_type &input, typename message_impl<Tag>::string_type &output)
     {
         static const char nop = -1; 
         static const char decoding_data[] = {
@@ -210,7 +210,7 @@ namespace boost { namespace network { namespace http {
     }
     
     template <typename Tag>
-    bool const message_impl<Tag>::base64_encode(typename message_impl<Tag>::string_type const & input, typename message_impl<Tag>::string_type & output)
+    bool message_impl<Tag>::base64_encode(typename message_impl<Tag>::string_type const & input, typename message_impl<Tag>::string_type & output)
     {
         static const char encoding_data[] = 
             "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
diff --git a/boost/network/protocol/http/message.hpp b/boost/network/protocol/http/message.hpp
@@ -60,15 +60,15 @@ namespace boost { namespace network { namespace http {
              * @param output decoded string ( may include non-text chars)
              * @return true if successful, false if input string contains non-base64 symbols
              */
-            static bool const base64_decode(string_type const &input, string_type & output);
+            static bool base64_decode(string_type const &input, string_type & output);
         
             /** encodes strings using base64
              *
              * @param input arbitrary string ( may include non-text chars)
              * @param output base64 encoded string
              * @return true if successful
              */
-            static bool const base64_encode(string_type const &input, string_type & output);
+            static bool base64_encode(string_type const &input, string_type & output);
 
     protected:
         mutable string_type version_;
@@ -100,7 +100,7 @@ namespace boost { namespace network { namespace http {
             status_ = status;
         }
 
-        boost::uint16_t const status() const {
+        boost::uint16_t status() const {
             return status_;
         }
 
diff --git a/boost/network/protocol/http/message/async_message.hpp b/boost/network/protocol/http/message/async_message.hpp
@@ -70,7 +70,7 @@ namespace boost { namespace network { namespace http {
             version_ = future;
         }
 
-        boost::uint16_t const status() const {
+        boost::uint16_t status() const {
             return status_.get();
         }
 
diff --git a/boost/network/protocol/http/server/storage_base.hpp b/boost/network/protocol/http/server/storage_base.hpp
@@ -15,7 +15,7 @@ namespace boost { namespace network { namespace http {
         struct has_io_service {};
     protected:
         template <class ArgPack>
-        server_storage_base(ArgPack const & args, no_io_service)
+        server_storage_base(ArgPack const & /* args */, no_io_service)
         : self_service_(new boost::asio::io_service())
         , service_(*self_service_)
         {}
diff --git a/boost/network/protocol/http/traits/impl/content.ipp b/boost/network/protocol/http/traits/impl/content.ipp
@@ -13,22 +13,22 @@ namespace boost { namespace network { namespace http {
 
     template <>
         struct content<tags::http_default_8bit_tcp_resolve> {
-            static char const * const type_html() {
+            static char const * type_html() {
                 static char const * const TYPE_HTML = "text/html";
                 return TYPE_HTML;
             };
 
-            static char const * const type_text() {
+            static char const * type_text() {
                 static char const * const TYPE_TEXT = "text/plain";
                 return TYPE_TEXT;
             };
 
-            static char const * const type_xml() {
+            static char const * type_xml() {
                 static char const * const TYPE_XML = "text/xml";
                 return TYPE_XML;
             };
 
-            static char const * const type_urlencoded() {
+            static char const * type_urlencoded() {
                 static char const * const TYPE_URLENCODED = "application/x-www-form-urlencoded";
                 return TYPE_URLENCODED;
             };
diff --git a/boost/network/protocol/http/traits/impl/delimiters.ipp b/boost/network/protocol/http/traits/impl/delimiters.ipp
@@ -14,17 +14,17 @@ namespace boost { namespace network { namespace http {
     // specialize on the tags::http_default_8bit_tcp_resolve type
     template <>
         struct delimiters<tags::http_default_8bit_tcp_resolve> {
-            static char const * const string_crlf() {
+            static char const * string_crlf() {
                 static char const * const CRLF = "\x0D\x0A";
                 return CRLF;
             };
 
-            static char const * const string_http_version() {
+            static char const * string_http_version() {
                 static char const * const HTTP_VERSION = "HTTP/1.1";
                 return HTTP_VERSION;
             };
 
-            static char const * const header_name_value_delimiter() {
+            static char const * header_name_value_delimiter() {
                 static char const * const HEADER_NAME_VALUE_DELIMITER = ": ";
                 return HEADER_NAME_VALUE_DELIMITER;
             };
diff --git a/boost/network/protocol/http/traits/impl/headers.ipp b/boost/network/protocol/http/traits/impl/headers.ipp
@@ -13,62 +13,62 @@ namespace boost { namespace network { namespace http {
 
     template <>
         struct headers_<tags::http_default_8bit_tcp_resolve> {
-            static char const * const host() {
+            static char const * host() {
                 static char const * const HOST = "Host";
                 return HOST;
             };
 
-            static char const * const cookie() {
+            static char const * cookie() {
                 static char const * const COOKIE = "Cookie";
                 return COOKIE;
             };
 
-            static char const * const set_cookie() {
+            static char const * set_cookie() {
                 static char const * const SET_COOKIE = "Set-Cookie";
                 return SET_COOKIE;
             };
 
-            static char const * const connection() {
+            static char const * connection() {
                 static char const * const CONNECTION = "Connection";
                 return CONNECTION;
             };
 
-            static char const * const content_type() {
+            static char const * content_type() {
                 static char const * const CONTENT_TYPE = "Content-Type";
                 return CONTENT_TYPE;
             };
 
-            static char const * const content_length() {
+            static char const * content_length() {
                 static char const * const CONTENT_LENGTH = "Content-Length";
                 return CONTENT_LENGTH;
             };
 
-            static char const * const content_location() {
+            static char const * content_location() {
                 static char const * const CONTENT_LOCATION = "Content-Location";
                 return CONTENT_LOCATION;
             };
 
-            static char const * const last_modified() {
+            static char const * last_modified() {
                 static char const * const LAST_MODIFIED = "Last-Modified";
                 return LAST_MODIFIED;
             };
 
-            static char const * const if_modified_since() {
+            static char const * if_modified_since() {
                 static char const * const IF_MODIFIED_SINCE = "If-Modified-Since";
                 return IF_MODIFIED_SINCE;
             };
 
-            static char const * const transfer_encoding() {
+            static char const * transfer_encoding() {
                 static char const * const TRANSFER_ENCODING = "Transfer-Encoding";
                 return TRANSFER_ENCODING;
             };
 
-            static char const * const location() {
+            static char const * location() {
                 static char const * const LOCATION = "Location";
                 return LOCATION;
             };
 
-            static char const * const authorization() {
+            static char const * authorization() {
                 static char const * const AUTHORIZATION = "Authorization";
                 return AUTHORIZATION;
             };
diff --git a/boost/network/protocol/http/traits/impl/request_methods.ipp b/boost/network/protocol/http/traits/impl/request_methods.ipp
@@ -13,27 +13,27 @@ namespace boost { namespace network { namespace http {
 
     template <>
         struct request_methods<tags::http_default_8bit_tcp_resolve> {
-            static char const * const head() {
+            static char const * head() {
                 static char const * const HEAD = "HEAD";
                 return HEAD;
             };
             
-            static char const * const get() {
+            static char const * get() {
                 static char const * const GET = "GET";
                 return GET;
             };
 
-            static char const * const put() {
+            static char const * put() {
                 static char const * const PUT = "PUT";
                 return PUT;
             };
 
-            static char const * const post() {
+            static char const * post() {
                 static char const * const POST = "POST";
                 return POST;
             };
 
-            static char const * const delete_() {
+            static char const * delete_() {
                 static char const * const DELETE_ = "DELETE";
                 return DELETE_;
             };
diff --git a/boost/network/protocol/http/traits/impl/response_message.ipp b/boost/network/protocol/http/traits/impl/response_message.ipp
@@ -13,57 +13,57 @@ namespace boost { namespace network { namespace http {
 
     template <>
         struct response_message<tags::http_default_8bit_tcp_resolve> {
-            static char const * const ok() {
+            static char const * ok() {
                 static char const * const OK = "OK";
                 return OK;
             };
 
-            static char const * const created() {
+            static char const * created() {
                 static char const * const CREATED = "Created";
                 return CREATED;
             };
 
-            static char const * const no_content() {
+            static char const * no_content() {
                 static char const * const NO_CONTENT = "NO Content";
                 return NO_CONTENT;
             };
 
-            static char const * const unauthorized() {
+            static char const * unauthorized() {
                 static char const * const UNAUTHORIZED = "Unauthorized";
                 return UNAUTHORIZED;
             };
 
-            static char const * const forbidden() {
+            static char const * forbidden() {
                 static char const * const FORBIDDEN = "Fobidden";
                 return FORBIDDEN;
             };
 
-            static char const * const not_found() {
+            static char const * not_found() {
                 static char const * const NOT_FOUND = "Not Found";
                 return NOT_FOUND;
             };
 
-            static char const * const method_not_allowed() {
+            static char const * method_not_allowed() {
                 static char const * const METHOD_NOT_ALLOWED = "Method Not Allowed";
                 return METHOD_NOT_ALLOWED;
             };
 
-            static char const * const not_modified() {
+            static char const * not_modified() {
                 static char const * const NOT_MODIFIED = "Not Modified";
                 return NOT_MODIFIED;
             };
 
-            static char const * const bad_request() {
+            static char const * bad_request() {
                 static char const * const BAD_REQUEST = "Bad Request";
                 return BAD_REQUEST;
             };
 
-            static char const * const server_error() {
+            static char const * server_error() {
                 static char const * const SERVER_ERROR = "Server Error";
                 return SERVER_ERROR;
             };
 
-            static char const * const not_implemented() {
+            static char const * not_implemented() {
                 static char const * const NOT_IMPLEMENTED = "Not Implemented";
                 return NOT_IMPLEMENTED;
             };
diff --git a/boost/network/utils/thread_pool.hpp b/boost/network/utils/thread_pool.hpp
@@ -68,7 +68,7 @@ namespace boost { namespace network { namespace utils {
             commit = true;
         }
 
-        std::size_t const thread_count() const {
+        std::size_t thread_count() const {
             return threads_;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ namespace boost { namespace network { namespace http {`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`template <typename Tag>`
`132`		`- bool const message_impl<Tag>::base64_decode(const typename message_impl<Tag>::string_type &input, typename message_impl<Tag>::string_type &output)`
	`132`	`+ bool message_impl<Tag>::base64_decode(const typename message_impl<Tag>::string_type &input, typename message_impl<Tag>::string_type &output)`
`133`	`133`	`{`
`134`	`134`	`static const char nop = -1;`
`135`	`135`	`static const char decoding_data[] = {`
`@@ -210,7 +210,7 @@ namespace boost { namespace network { namespace http {`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`template <typename Tag>`
`213`		`- bool const message_impl<Tag>::base64_encode(typename message_impl<Tag>::string_type const & input, typename message_impl<Tag>::string_type & output)`
	`213`	`+ bool message_impl<Tag>::base64_encode(typename message_impl<Tag>::string_type const & input, typename message_impl<Tag>::string_type & output)`
`214`	`214`	`{`
`215`	`215`	`static const char encoding_data[] =`
`216`	`216`	`"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ namespace boost { namespace network { namespace http {`
`70`	`70`	`version_ = future;`
`71`	`71`	`}`
`72`	`72`
`73`		`- boost::uint16_t const status() const {`
	`73`	`+ boost::uint16_t status() const {`
`74`	`74`	`return status_.get();`
`75`	`75`	`}`
`76`	`76`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ namespace boost { namespace network { namespace utils {`
`68`	`68`	`commit = true;`
`69`	`69`	`}`
`70`	`70`
`71`		`- std::size_t const thread_count() const {`
	`71`	`+ std::size_t thread_count() const {`
`72`	`72`	`return threads_;`
`73`	`73`	`}`
`74`	`74`