Skip to content

Commit 05b3449

Browse files
author
Paweł Andruszkiewicz
committed
Improve performance of JS tests
The configuration of automatic JS tests was executing the setup.js script twice, this has been fixed. Change-Id: Ia00b63824f27e99ee5798bdcf124889f2406077f
1 parent ec24925 commit 05b3449

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

unittest/auto_script_js_t.cc

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -239,14 +239,6 @@ class Auto_script_js : public Shell_js_script_tester,
239239
execute_setup();
240240
}
241241

242-
// todo(kg): _norecord files haven't defined functions from script.js, e.g.
243-
// `EXPECT_NE`. reset_replayable_shell call reset_shell therefore we lost
244-
// those previously defined and called in constructor functions.
245-
// I run setup.js script here once again, but this should be done somewhere
246-
// else, but I don't know where.
247-
set_setup_script(shcore::path::join_path(g_test_home, "scripts", "setup_js",
248-
"setup.js"));
249-
250242
if (g_mysqld_path_variables && folder == "js_mixed_versions") {
251243
auto variables = shcore::str_split(g_mysqld_path_variables, ",");
252244

@@ -278,9 +270,6 @@ class Auto_script_js : public Shell_js_script_tester,
278270
}
279271
}
280272

281-
const std::vector<std::string> argv;
282-
_interactive_shell->process_file(_setup_script, argv);
283-
284273
execute("const __script_file = '" + GetParam() + "'");
285274

286275
set_config_folder("auto/" + folder);

0 commit comments

Comments
 (0)