Improving GraalVM Integration

- Adds proper error handling when failures occur switching shell mode.
- Updates the polyglot library to return the actual error codes in
  case of initialization failures and adds debugging support.
- Updates the shell to print the initialization error codes coming from
  the polyglot library.

Change-Id: Ie8a7bb0d51df44ee8b92d0d427d6a62b986e0eec

Author: rennox

ext/polyglot/polyglot-nativeapi/patches/enhancements.patch

@@ -1,5 +1,5 @@
 diff --git a/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPI.java b/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPI.java
-index 1ed21c307..7006dbd44 100644
+index 1ed21c307..496663aec 100644
 --- a/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPI.java
 +++ b/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPI.java
 @@ -28,23 +28,60 @@ import static org.graalvm.polyglot.nativeapi.types.PolyglotNativeAPITypes.Polygl
@@ -2616,3 +2616,16 @@ index 1ed21c307..7006dbd44 100644
      @CEntryPoint(name = "poly_context_builder_timezone", exceptionHandler = ExceptionHandler.class, documentation = {
                      "Sets timezone for a <code>poly_context_builder</code>.",
                      "",
+diff --git a/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPIEntryPoints.java b/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPIEntryPoints.java
+index a227d9c9e..58a723a15 100644
+--- a/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPIEntryPoints.java
++++ b/src/main/java/org/graalvm/polyglot/nativeapi/PolyglotNativeAPIEntryPoints.java
+@@ -104,7 +104,7 @@ public final class PolyglotNativeAPIEntryPoints {
+                     "the thread is detached."})
+     @CEntryPointOptions(prologue = NoPrologue.class, epilogue = NoEpilogue.class, nameTransformation = UnchangedNameTransformation.class)
+     public static @CTypedef(name = "poly_status") int polyCreateIsolate(@CConst PolyglotIsolateParameters params, PolyglotIsolatePointer isolate, PolyglotIsolateThreadPointer thread) {
+-        return createIsolate(params, isolate, thread) == 0 ? Poly.ok() : Poly.generic_failure();
++        return createIsolate(params, isolate, thread);
+     }
+
+     @Uninterruptible(reason = UNINTERRUPTIBLE_REASON)

ext/polyglot/polyglot-nativeapi/pom.xml

@@ -21,12 +21,6 @@
 
     <dependencies>
 
-        <dependency>
-            <groupId>org.graalvm.polyglot</groupId>
-            <artifactId>polyglot</artifactId>
-            <version>${graalvm.version}</version>
-        </dependency>
-
         <dependency>
             <groupId>org.graalvm.nativeimage</groupId>
             <artifactId>svm</artifactId>

ext/polyglot/pom.xml

@@ -22,12 +22,34 @@
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>org.graalvm.polyglot</groupId>
+            <artifactId>polyglot</artifactId>
+            <version>${graalvm.version}</version>
+        </dependency>
+
         <dependency>
             <groupId>org.graalvm.polyglot</groupId>
             <artifactId>js-community</artifactId>
             <version>${graalvm.version}</version>
             <type>pom</type>
         </dependency>
+
+        <dependency>
+            <groupId>org.graalvm.polyglot</groupId>
+            <artifactId>dap-community</artifactId>
+            <version>${graalvm.version}</version>
+            <type>pom</type>
+            <scope>runtime</scope>
+        </dependency>
+
+        <dependency>
+            <groupId>org.graalvm.polyglot</groupId>
+            <artifactId>inspect-community</artifactId>
+            <version>${graalvm.version}</version>
+            <type>pom</type>
+            <scope>runtime</scope>
+        </dependency>
     </dependencies>
 
     <profiles>

mysqlshdk/scripting/polyglot/languages/polyglot_common_context.cc

@@ -25,6 +25,7 @@
 
 #include "mysqlshdk/scripting/polyglot/languages/polyglot_common_context.h"
 
+#include "mysqlshdk/libs/utils/utils_string.h"
 #include "mysqlshdk/scripting/polyglot/native_wrappers/polyglot_collectable.h"
 #include "mysqlshdk/scripting/polyglot/utils/polyglot_error.h"
 #include "mysqlshdk/scripting/polyglot/utils/polyglot_scope.h"
@@ -34,8 +35,10 @@ namespace shcore {
 namespace polyglot {
 
 void Polyglot_common_context::initialize() {
-  if (poly_ok != poly_create_isolate(NULL, &m_isolate, &m_thread)) {
-    throw Polyglot_generic_error("Error creating polyglot isolate");
+  if (const auto rc = poly_create_isolate(NULL, &m_isolate, &m_thread);
+      poly_ok != rc) {
+    throw Polyglot_generic_error(
+        shcore::str_format("Error creating polyglot isolate: %d", rc));
   }
 
   m_garbage_collector.start(gc_config(), m_isolate);

mysqlshdk/shellcore/shell_core.cc

@@ -178,8 +178,14 @@ bool Shell_core::switch_mode(Mode mode) {
   m_help.set_mode(mode);
 
   if (_mode != mode) {
+    Mode backup_mode = _mode;
     _mode = mode;
-    init_mode(_mode);
+    try {
+      init_mode(_mode);
+    } catch (...) {
+      _mode = backup_mode;
+      throw;
+    }
     return true;
   }
   return false;