BUG#37154456 Write compatibility issues and applied fixes to the log file

The compatibility issues found when running a dump with the `ocimds`
option set to true are already printed to the Shell log, with this
change all issues detected by the upgrade checker are also written
there.

Change-Id: I50b3f1f9449d48b30c52fed1446e99a0980ad050

Author: Paweł Andruszkiewicz

modules/util/upgrade_check_formatter.cc

@@ -84,27 +84,40 @@ class Text_upgrade_checker_output : public Upgrade_check_output_formatter {
     if (results.empty()) {
       print_paragraph("No issues found");
     } else if (check.get_description() != nullptr) {
+      log(check.get_level(), check.get_description());
       print_paragraph(check.get_description());
       print_doc_links(check.get_doc_link());
       m_console->println();
     } else {
       issue_formater = format_upgrade_issue;
     }
 
-    for (const auto &issue : results) print_paragraph(issue_formater(issue));
+    for (const auto &issue : results) {
+      const auto msg = issue_formater(issue);
+      log(issue.level, msg.c_str());
+      print_paragraph(msg);
+    }
   }
 
   void check_error(const Upgrade_check &check, const char *description,
                    bool runtime_error = true) override {
     print_title(check.get_title());
     m_console->print("  ");
-    if (runtime_error) m_console->print_diag("Check failed: ");
+
+    if (runtime_error) {
+      static constexpr auto k_check_failed = "Check failed: ";
+      log(Upgrade_issue::Level::ERROR, k_check_failed);
+      m_console->print_diag(k_check_failed);
+    }
+
+    log(Upgrade_issue::Level::ERROR, description);
     m_console->println(description);
     print_doc_links(check.get_doc_link());
   }
 
   void manual_check(const Upgrade_check &check) override {
     print_title(check.get_title());
+    log(check.get_level(), check.get_description());
     print_paragraph(check.get_description());
     print_doc_links(check.get_doc_link());
   }
@@ -148,6 +161,22 @@ class Text_upgrade_checker_output : public Upgrade_check_output_formatter {
     }
   }
 
+  void log(Upgrade_issue::Level level, const char *msg) {
+    switch (level) {
+      case Upgrade_issue::Level::ERROR:
+        log_error("%s", msg);
+        break;
+
+      case Upgrade_issue::Level::WARNING:
+        log_warning("%s", msg);
+        break;
+
+      case Upgrade_issue::Level::NOTICE:
+        log_info("%s", msg);
+        break;
+    }
+  }
+
   int m_check_count = 0;
   std::shared_ptr<IConsole> m_console;
 };

unittest/scripts/auto/py_shell/scripts/util_dump_instance_norecord.py

@@ -1613,6 +1613,8 @@ def EXPECT_INCLUDE_EXCLUDE(options, included, excluded, expected_exception = Non
     excluded_tables.append("`{0}`.`{1}`".format(test_schema, table))
 
 recreate_verification_schema()
+WIPE_SHELL_LOG()
+
 EXPECT_FAIL("Error: Shell Error (52004)", "While 'Validating MySQL HeatWave Service compatibility': Compatibility issues were found", test_output_relative, { "ocimds": True, "excludeSchemas": excluded_schemas, "excludeTables": excluded_tables })
 
 # BUG#35663805 print a note to always use the lastest shell
@@ -1624,6 +1626,12 @@ def EXPECT_INCLUDE_EXCLUDE(options, included, excluded, expected_exception = Non
     EXPECT_STDOUT_CONTAINS("NOTE: MySQL Server 5.7 detected, please consider upgrading to 8.0 first.")
     EXPECT_STDOUT_CONTAINS("Checking for potential upgrade issues.")
 
+# BUG#37154456 write compatibility issues and applied fixes to the log file
+EXPECT_SHELL_LOG_CONTAINS(strip_restricted_grants(test_user_account, test_privileges).error_no_prefix())
+EXPECT_SHELL_LOG_CONTAINS(comment_data_index_directory(incompatible_schema, incompatible_table_data_directory).fixed_no_prefix())
+if __version_num < 80000:
+    EXPECT_SHELL_LOG_CONTAINS("Warning: The new default authentication plugin 'caching_sha2_password' offers more secure password hashing than previously used 'mysql_native_password' (and consequent improved client connection authentication). However, it also has compatibility implications that may affect existing MySQL installations.  If your MySQL installation must serve pre-8.0 clients, you may encounter compatibility issues after upgrading unless newly created accounts are created to use 'mysql_native_password'.")
+
 EXPECT_STDOUT_CONTAINS(strip_restricted_grants(test_user_account, test_privileges).error())
 
 EXPECT_STDOUT_CONTAINS(comment_data_index_directory(incompatible_schema, incompatible_table_data_directory).fixed())

unittest/scripts/setup_py/dump_utils.inc

@@ -251,16 +251,22 @@ class Compatibility_issue:
             return self.__error_msg
         else:
             raise Exception("No error message")
+    def error_no_prefix(self):
+        return self.error()[7:]
     def warning(self):
         if self.__warning_msg:
             return self.__warning_msg
         else:
             raise Exception("No warning message")
+    def warning_no_prefix(self):
+        return self.warning()[9:]
     def fixed(self):
         if self.__fixed_msg:
             return self.__fixed_msg
         else:
             raise Exception("No fixed message")
+    def fixed_no_prefix(self):
+        return self.fixed()[6:]
 
 def strip_restricted_grants(user, privileges):
     all_privileges = ", ".join(sorted(privileges))