Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: php/php-src
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: nikic/php-src
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: engineExceptions
Choose a head ref
  • 6 commits
  • 126 files changed
  • 1 contributor

Commits on Oct 18, 2013

  1. Move most E_ERROR in vm_def to EngineException

    @nikic
    nikic committed Oct 18, 2013
    Configuration menu
    Copy the full SHA
    523d0c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2013

  1. Move argument type checking to exceptions

    @nikic
    nikic committed Oct 19, 2013
    Configuration menu
    Copy the full SHA
    220c686 View commit details
    Browse the repository at this point in the history

  2. Move Closure/Generator construction errors to exceptions

    @nikic
    nikic committed Oct 19, 2013
    Configuration menu
    Copy the full SHA
    1f1b097 View commit details
    Browse the repository at this point in the history

  3. Add ZEND_IMPOSSIBLE macro 

    This macro can be used to highlight branches that cannot be reached.
It behaves the same way as an assert(0) with a message.

    ZEND_IMPOSSIBLE("This can't be reached")
    /* equals */
    ZEND_ASSERT(0 && "This can't be reached")
    @nikic
    nikic committed Oct 19, 2013
    Configuration menu
    Copy the full SHA
    c4eb434 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2013

  1. Fix tests outside Zend/ and tests/ 

    This fixes only the disable-all build, with more extensions there
are likely more failures that need to be changed.
    @nikic
    nikic committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    bcd2570 View commit details
    Browse the repository at this point in the history

  2. Remove last E_ERROR in zend_vm_def.h 

    After further considertion simply throwing an exception is safe
here.
    @nikic
    nikic committed Oct 22, 2013
    Configuration menu
    Copy the full SHA
    f6580f7 View commit details
    Browse the repository at this point in the history
Loading