check the comments array boundry

dota17 · dota17 · commit 75df7896210c · 2019-09-12T11:34:55.000+08:00
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -1467,7 +1467,11 @@ void Value::Comments::set(CommentPlacement slot, String comment) {
   if (!ptr_) {
     ptr_ = std::unique_ptr<Array>(new Array());
   }
-  (*ptr_)[slot] = std::move(comment);
+  // check comments array boundry.
+  if (slot < CommentPlacement::numberOfCommentPlacement) {
+    (*ptr_)[slot] = std::move(comment);
+  }
+
 }
 
 void Value::setComment(String comment, CommentPlacement placement) {

Original file line number	Diff line number	Diff line change
`@@ -1467,7 +1467,11 @@ void Value::Comments::set(CommentPlacement slot, String comment) {`
`1467`	`1467`	`if (!ptr_) {`
`1468`	`1468`	`ptr_ = std::unique_ptr<Array>(new Array());`
`1469`	`1469`	`}`
`1470`		`- (*ptr_)[slot] = std::move(comment);`
	`1470`	`+ // check comments array boundry.`
	`1471`	`+ if (slot < CommentPlacement::numberOfCommentPlacement) {`
	`1472`	`+ (*ptr_)[slot] = std::move(comment);`
	`1473`	`+ }`
	`1474`	`+`
`1471`	`1475`	`}`
`1472`	`1476`
`1473`	`1477`	`void Value::setComment(String comment, CommentPlacement placement) {`